Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Mar 2016 22:13:47 -0800
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r296406 - head/lib
Message-ID:  <56DA791B.2030205@FreeBSD.org>
In-Reply-To: <201603050539.u255dxQl080458@repo.freebsd.org>
References:  <201603050539.u255dxQl080458@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 3/4/16 9:39 PM, Bryan Drewery wrote:
> Author: bdrewery
> Date: Sat Mar  5 05:39:59 2016
> New Revision: 296406
> URL: https://svnweb.freebsd.org/changeset/base/296406
> 
> Log:
>   Revert r296395.
>   
>   This mistakenly removed the SUBDIR_PARALLEL but even worse is that the install
>   (and build) order is not correct due to the lack of SUBDIR_DEPEND on the
>   most critical libraries.  The only reason they build correctly now is because
>   buildworld's 'make libraries' orders them properly.

Bonus, the addition of SUBDIR_DEPEND in lib/Makefile in r267511
technically breaks non-parallel builds since it de-ordered everything
and has relied on the ordering in Makefile.inc1 even more.

I had tried to make bsd.subdir.mk create targets for each subdir even
without -j before mostly as an attempt to simplify it some.  If I can
pull that off though then we can use the SUBDIR_DEPEND for non-parallel
builds as well.

-- 
Regards,
Bryan Drewery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56DA791B.2030205>