From owner-freebsd-hackers@freebsd.org Wed Jun 12 13:01:05 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 744FC15B55A1 for ; Wed, 12 Jun 2019 13:01:05 +0000 (UTC) (envelope-from huangfq.daxian@gmail.com) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E210751C1 for ; Wed, 12 Jun 2019 13:01:04 +0000 (UTC) (envelope-from huangfq.daxian@gmail.com) Received: by mail-yb1-xb36.google.com with SMTP id d2so6353274ybh.8 for ; Wed, 12 Jun 2019 06:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=J/vCnni50Fqj+2qkKQkc1tAQ6DCGBWSlTNndCVOXgrU=; b=Tu0cagbgX3814sRrpqL/HuiFdIsB/Ez0DJMGbuGTzXCFVan9xEywtSvlGjh3oM4TX7 OKhv4QEEWtaB5ASNfHk0SFKLr47jmeO4/LGIs1VvUDIUNcnFgRIP2Ire5zarCTvXhz16 WQhX8H/nPW44q5f7p83hNtf0Dxf6lzRQsIHatS+EFUR8xR+PhO0rFET39DYkMOR3u1Uv GyBKxrV7KQXXYnKX2V3aKWM0G0UPJZJzDiaNBsCHufWXAM5TOqshMbtTgNYaz1AIbKBo F2csnAIHxjDWAy6fzQCtiybi0rIz6QJXnZE+SOBk6BIPW1TnWStXR9J/kvDk+iwE1e+R cugw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=J/vCnni50Fqj+2qkKQkc1tAQ6DCGBWSlTNndCVOXgrU=; b=MRsceHBNxJTfkWl1q8XsiceOGOBaiVhNiqMfh7DTzBm5HViklB158pqT4bvMNkYNPj vh8yIOJff4OGzrXQ6wU1yK9ZZVm5y0HTDWxLzxVtFK1NPgS0G/9+Sko9ldWPRvoz/OLF ZarVSSLwX7rHqBWw2KNCaV+a2H4DsTw8Y+MZP+2657nkRiD8q31NlvscLpn35uc5tL1l esXIEBPNDyR/UQ8UQ01lN0tEB6JUvkYNMHhGd/fBT8xK9LiicuZpONdMWcwYCt6sl+AV CCEycvVver+M3fiBpvwDQW630/EePrLi+9YWMODXomY2e5+fxhBJpXIDV2iQ5+l459Ih 1PeA== X-Gm-Message-State: APjAAAUcqIzDTlkil+wTaE4vsy/KzDjCOlz8/mUvQwBUKxW1g+BLBKfV Vg8N64Hd9R+dP9Sv1/Q6osbUpiYSiBZhAwYTIN+T+tXjQSk= X-Google-Smtp-Source: APXvYqxnE8/V8znEbbagY+vtwXvUktvZk27RFylcKBsSkH1Coxw5uzmYLwR30dJXPb1VSN60TM4Hq9iaa67FP7ILCBI= X-Received: by 2002:a25:d113:: with SMTP id i19mr40753817ybg.277.1560344463822; Wed, 12 Jun 2019 06:01:03 -0700 (PDT) MIME-Version: 1.0 From: Fuqian Huang Date: Wed, 12 Jun 2019 21:00:52 +0800 Message-ID: Subject: Dev:Ciss: A kernel address leakage in sys/dev/ciss/ciss.c To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9E210751C1 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Tu0cagbg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of huangfqdaxian@gmail.com designates 2607:f8b0:4864:20::b36 as permitted sender) smtp.mailfrom=huangfqdaxian@gmail.com X-Spamd-Result: default: False [-6.89 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.93)[-0.932,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-2.94)[ip: (-9.20), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.30), country: US(-0.06)]; RCVD_IN_DNSWL_NONE(0.00)[6.3.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jun 2019 13:01:05 -0000 In freebsd/sys/dev/ciss/ciss.c, function ciss_print_request will dump the address of a kernel object cr to user space. Each time when a device is detached, it will call ciss_free->ciss_notify_abort->ciss_print_request, and this finally dump a kernel address to user space. static int ciss_detach(device_t dev) { struct ciss_softc *sc = device_get_softc(dev); ... ciss_free(sc); return (0); } static void ciss_free(struct ciss_softc *sc) { ... -> ciss_notify_abort(sc); ... } static int ciss_notify_abort(struct ciss_softc *sc) { struct ciss_request *cr; ... if ((error = ciss_get_request(sc, &cr)) goto out; ... -> ciss_print_request(cr); ... } static void ciss_print_request(struct ciss_request *cr) { struct ciss_softc *sc; ... sc = cr->cr_sc; ... -> ciss_printf(sc, "REQUEST @ %p\n", cr); ciss_printf(sc, " data %p/%d tag %d flags %b\n", cr->cr_data, cr->cr_length, cr->cr_tag, cr->cr_flags, "\20\1mapped\2sleep\3poll\4dataout\5datain\n"); }