From owner-cvs-all  Sat Sep 28 19:30:51 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7B17A37B401; Sat, 28 Sep 2002 19:30:50 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 35AF943E65; Sat, 28 Sep 2002 19:30:49 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id MAA03767;
	Sun, 29 Sep 2002 12:30:47 +1000
Date: Sun, 29 Sep 2002 12:40:05 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Juli Mallett <jmallett@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/make main.c
In-Reply-To: <200209290002.g8T025P0072694@freefall.freebsd.org>
Message-ID: <20020929122637.P39746-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sat, 28 Sep 2002, Juli Mallett wrote:

> jmallett    2002/09/28 17:02:05 PDT
>
>   Modified files:
>     usr.bin/make         main.c
>   Log:
>   Fix ability to use csh(1) as the make(1) shell.
>
>   Sponsored by:   Bright Path Solutions
>
>   Revision  Changes    Path
>   1.73      +3 -1      src/usr.bin/make/main.c

Shouldn't this be -1 +3 to remove any such ability, since such ability is
a bug? :-)

The most interesting aspects of using wrong shells for make(1) don't seem
to have been addressed:
- POSIX requires the shell to be the standard one and doesn't permit the
  environment variable SHELL to affect this; it requires unusual handlng
  of SHELL which isn't implemented.
- make(1)'s .SHELL variable provides much more powerful foot-shooting than
  the MAKE_SHELL hack, except at least the documented example of using it
  doesn't actually work (see the tutorial for the documentation).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message