From owner-cvs-all@FreeBSD.ORG Wed Jan 21 17:47:39 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68AA216A4CE; Wed, 21 Jan 2004 17:47:39 -0800 (PST) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id A82FE43D3F; Wed, 21 Jan 2004 17:47:36 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i0M1lZtd016290; Thu, 22 Jan 2004 12:47:35 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i0M1lYfe024924; Thu, 22 Jan 2004 12:47:34 +1100 Date: Thu, 22 Jan 2004 12:47:34 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Don Lewis In-Reply-To: <200401211257.i0LCvr7E061707@gw.catspoiler.org> Message-ID: <20040122124351.H10548@gamplex.bde.org> References: <200401211257.i0LCvr7E061707@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: phk@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2004 01:47:39 -0000 On Wed, 21 Jan 2004, Don Lewis wrote: > On 21 Jan, Bruce Evans wrote: > > On Tue, 20 Jan 2004, Don Lewis wrote: > > > >> What about the case of macros like KASSERT() and the vnode lock > >> assertions? Won't they report the name and line number of the #define? > > > > Er, macros don't work like that. > > > > KASSERT() expands to a call to panic() (and other things) inline, so > > it gets the name and line number from the file that has the KASSERT(). > > I could swear that I've ended up in .h files when doing kernel > debugging. My simple userland test case acts like you describe. I > suspect what I'm thinking of is the inline functions in vnode_if.h. Yes, support for debugging inline functions can be too good in some cases. Low-level inlines like __curthread() are especially uninteresting. Bruce