From owner-svn-ports-all@FreeBSD.ORG Mon Feb 10 15:45:57 2014 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D15E9D0; Mon, 10 Feb 2014 15:45:57 +0000 (UTC) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E495E1987; Mon, 10 Feb 2014 15:45:56 +0000 (UTC) Received: from mouf.net (swills@mouf [199.48.129.64]) by mouf.net (8.14.5/8.14.5) with ESMTP id s1AFjkuw000479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 10 Feb 2014 15:45:51 GMT (envelope-from swills@mouf.net) Received: (from swills@localhost) by mouf.net (8.14.5/8.14.5/Submit) id s1AFjkmH000478; Mon, 10 Feb 2014 15:45:46 GMT (envelope-from swills) Date: Mon, 10 Feb 2014 15:45:45 +0000 From: Steve Wills To: marino@FreeBSD.org Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210154545.GB99571@mouf.net> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <52F87BB2.3070402@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52F87BB2.3070402@marino.st> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Mon, 10 Feb 2014 15:45:51 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mouf.net X-Virus-Scanned: clamav-milter 0.97.8 at mouf.net X-Virus-Status: Clean Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2014 15:45:57 -0000 On Mon, Feb 10, 2014 at 08:11:46AM +0100, John Marino wrote: > On 2/10/2014 02:17, Steve Wills wrote: > > On Sun, Feb 09, 2014 at 11:29:17PM +0000, John Marino wrote: > >> Author: marino > >> Date: Sun Feb 9 23:29:16 2014 > >> New Revision: 343559 > >> URL: http://svnweb.freebsd.org/changeset/ports/343559 > >> QAT: https://qat.redports.org/buildarchive/r343559/ > >> > >> Log: > >> net-p2p/litecoin: Fix DragonFly (broken by OSVERSION) > >> > >> Limit OSVERSION-based modifications to FreeBSD. This port suddenly > >> broken and the use of OSVERSION without OPSYS was the cause. > >> > >> Modified: > >> head/net-p2p/litecoin/Makefile > >> > >> Modified: head/net-p2p/litecoin/Makefile > >> ============================================================================== > >> --- head/net-p2p/litecoin/Makefile Sun Feb 9 23:18:17 2014 (r343558) > >> +++ head/net-p2p/litecoin/Makefile Sun Feb 9 23:29:16 2014 (r343559) > >> @@ -75,7 +75,7 @@ QMAKE_USE_DBUS= 0 > >> PLIST_FILES+= share/applications/litecoin-qt.desktop share/pixmaps/litecoin64.png > >> .endif > >> > >> -.if ${OSVERSION} >= 1000054 > >> +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000054 > >> EXTRA_PATCHES+= ${FILESDIR}/extra-patch-endian > >> .endif > >> > > > > Shouldn't this have required maintainer approval? Or am I confused? > > > > According to _my_ interpretation of the "just fix it" blanket, no. This > is on par with a typographical error. The cause of the recent breakage > is obvious, the fix is obvious, there's no reason for the maintainer to > object. Why would an OSVERSION fix require the formality of maintainer > approval? Ah, ok. Works for me. I only noticed it because I was removing those lines and got a conflict. I didn't even know we were supporting DragonFly now, but I guess I missed a memo as usual. Steve