Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Aug 2024 19:35:18 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 280734] [NEW PORT] deskutil/ximaging: Image Viewer and Browser for Unix/X11
Message-ID:  <bug-280734-7788-ttKPSS4gkO@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-280734-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-280734-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280734

--- Comment #1 from Vladimir Druzenko <vvd@FreeBSD.org> ---
1. Alphabetically sort records:
LIB_DEPENDS+=3D   libtiff.so:graphics/tiff libpng16.so:graphics/png
USES=3D           tar:xz motif jpeg
USE_XORG=3D       xt xinerama x11
=3D>
LIB_DEPENDS=3D    libpng16.so:graphics/png \
                libtiff.so:graphics/tiff
USES=3D           jpeg motif tar:xz
USE_XORG=3D       x11 xinerama xt

2. Not needed "+": LIB_DEPENDS+=3D =3D> LIB_DEPENDS=3D

3. CATEGORIES=3Ddeskutils, why not graphics?

4. Try to replace DISTNAME=3Dximaging-src-${DISTVERSION} with
DISTVERSIONPREFIX=3Dsrc-

5.
${INSTALL_PROGRAM} ${WRKSRC}/src/ximaging ${STAGEDIR}${PREFIX}/bin/ximaging
=3D>
${INSTALL_PROGRAM} ${WRKSRC}/src/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

${INSTALL_MAN} ${WRKSRC}/src/ximaging.1
${STAGEDIR}${PREFIX}/share/man/man1/ximaging.1
=3D>
${INSTALL_MAN} ${WRKSRC}/src/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/share/man/m=
an1

6. Less than 6 lines in pkg-plist recommended to replace with PLIST_FILES in
Makefile:
PLIST_FILES=3D bin/ximaging \
             etc/X11/app-defaults/XImaging \
             share/man/man1/ximaging.1.gz

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280734-7788-ttKPSS4gkO>