From owner-svn-src-head@freebsd.org  Sat Jan  9 21:31:33 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEA42A6AC6D;
 Sat,  9 Jan 2016 21:31:33 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 984771A7E;
 Sat,  9 Jan 2016 21:31:33 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u09LVWRF024149
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 9 Jan 2016 13:31:32 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u09LVWo8024148;
 Sat, 9 Jan 2016 13:31:32 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sat, 9 Jan 2016 13:31:32 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Antoine Brodin <antoine@FreeBSD.org>
Cc: Dirk Meyer <dinoex@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r293439 - in head: lib/libc/sys sys/dev/ti sys/kern
 sys/sys usr.bin/netstat
Message-ID: <20160109213132.GT1906@FreeBSD.org>
References: <201601082034.u08KYvLv075281@repo.freebsd.org>
 <CAALwa8nV83EWy1+zLxvSt4oSrXo_uw994nnukhEF-oqW_mVnBQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAALwa8nV83EWy1+zLxvSt4oSrXo_uw994nnukhEF-oqW_mVnBQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jan 2016 21:31:33 -0000

  Antoine,

On Sat, Jan 09, 2016 at 07:41:57PM +0000, Antoine Brodin wrote:
A> On Fri, Jan 8, 2016 at 8:34 PM, Gleb Smirnoff <glebius@freebsd.org> wrote:
A> > Author: glebius
A> > Date: Fri Jan  8 20:34:57 2016
A> > New Revision: 293439
A> > URL: https://svnweb.freebsd.org/changeset/base/293439
A> >
A> > Log:
A> >   New sendfile(2) syscall. A joint effort of NGINX and Netflix from 2013 and
A> >   up to now.
A> 
A> Hi,
A> 
A> "SF_FLAGS" addition seems to break graphics/graphviz on head.
A> See error log at:
A> http://beefy3.nyi.freebsd.org/data/head-i386-default/p405601_s293454/logs/errors/graphviz-2.38.0_10.log
A> 739 ports are skipped due to this failure.

I'm reluctant to fix that on our side. The problem comes
from lib/sfio/sfhdr.h in graphviz. This file first includes
"sfio_t.h", a local definitions file, and then includes system
includes. This is clearly an mistake, and the breakage is
exactly the consequence of such kind of mistakes. I can't
imagine a situation when you do want system wide definitions
to overtake yours.

So I suggest to put a patch in the port and submit it upstream.
Any objections? I can do it myself, but would be grateful if
maintainer provides help.

-- 
Totus tuus, Glebius.