From owner-svn-src-stable-9@FreeBSD.ORG Fri Jan 6 14:51:20 2012 Return-Path: Delivered-To: svn-src-stable-9@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0AAB106566B; Fri, 6 Jan 2012 14:51:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id B0AA28FC16; Fri, 6 Jan 2012 14:51:20 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 5139F46B0A; Fri, 6 Jan 2012 09:51:20 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AF762B960; Fri, 6 Jan 2012 09:51:19 -0500 (EST) From: John Baldwin To: Gleb Smirnoff Date: Fri, 6 Jan 2012 09:50:13 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; ) References: <201201051950.q05JoCKj052356@svn.freebsd.org> <201201060845.13174.jhb@freebsd.org> <20120106142459.GR34721@FreeBSD.org> In-Reply-To: <20120106142459.GR34721@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Message-Id: <201201060950.13736.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 06 Jan 2012 09:51:19 -0500 (EST) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r229633 - stable/9/sys/net X-BeenThere: svn-src-stable-9@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 9-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 14:51:21 -0000 On Friday, January 06, 2012 9:24:59 am Gleb Smirnoff wrote: > On Fri, Jan 06, 2012 at 08:45:12AM -0500, John Baldwin wrote: > J> On Friday, January 06, 2012 3:20:05 am Gleb Smirnoff wrote: > J> > John, > J> > > J> > On Thu, Jan 05, 2012 at 07:50:12PM +0000, John Baldwin wrote: > J> > J> Author: jhb > J> > J> Date: Thu Jan 5 19:50:12 2012 > J> > J> New Revision: 229633 > J> > J> URL: http://svn.freebsd.org/changeset/base/229633 > J> > J> > J> > J> Log: > J> > J> MFC 228089: > J> > J> Change the if_vlan driver to use if_transmit for forwarding packets to the > J> > J> parent interface. This avoids the overhead of queueing a packet to an IFQ > J> > J> only to immediately dequeue it again. > J> > > J> > This should have been merged together with r228967. Now a bug that > J> > was successfully discovered and fixed in head/ leaked to stable > J> > branches. :( > J> > > J> > Can you please merge r228967 to stable/9 and stable/8 ASAP? > J> > J> Err, that bug was already present before this change. I did not expose it. > J> > J> I can MFC the stat fixes, but this was already broken in 8 and 9, and is > J> broken in 7 as well (likely in older branches than that). > > Well, on 8.2-STABLE if_obytes are correctly accounted: > > glebius@xxx:~:|>netstat -hI vlan2 1 > input (vlan2) output > packets errs idrops bytes packets errs bytes colls > 33 0 0 2.3k 4 0 840 0 > 36 0 0 2.4k 4 0 442 0 > 32 0 0 2.3k 6 0 887 0 > > glebius@xxx:~:|>uname -v > FreeBSD 8.2-STABLE #2: Wed Jul 6 13:22:13 MSD 2011 > > While on 228089 =< head < 228967 they are not: > > glebius@xxx2:~:|>netstat -hI vlan77 1 > input (vlan77) output > packets errs idrops bytes packets errs bytes colls > 9.1k 0 0 2M 12k 0 0 0 > 11k 0 0 4.3M 14k 0 0 0 > 10k 0 0 2.8M 14k 0 0 0 > 9.4k 0 0 2.3M 13k 0 0 0 > > glebius@xxx2:~:|>uname -v > FreeBSD 10.0-CURRENT #5 r228769M: Thu Dec 22 19:44:57 MSK 2011 Hmm, it seems to be a side effect of the IFQ macros. -- John Baldwin