From owner-svn-src-all@freebsd.org Thu Jul 4 14:56:38 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AAD115D75B8; Thu, 4 Jul 2019 14:56:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C1E79477F; Thu, 4 Jul 2019 14:56:37 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd44.google.com with SMTP id s7so13327964iob.11; Thu, 04 Jul 2019 07:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YUD+yROtQGAg2gRUjLOynKW9CQNfydepZgHMrXGgs+E=; b=EgvNc4wv1oSK3mdN1j9hQa1MmKT1jXNC1zIy9WIj4SjOPkXoq5JND3RF0c7sG/UEpp S2mDqWSOkG6wOssq0ZKSZFyRf/AgUiTJP2ma/jjYcjHK/BTqlz3jfDToxcg++CRqmbMW xURAGMIJlEacmtuYz8FIMvVu6sShxiLg1M3CJie3y3ofNTmZw6miXMH6BtiFPzGnSows d7VjcauvcC8C3vy/ogagM0cHb3xAm26tOjFgJb3PnbrCmh0hbz1A4vmYl11zsb3M2GCs xQ0cj4pwcVTqhDoHC88amHle/S5QwenbAYZilCLfUDGJs7scNa9zhdY1hJY5AyIqX8Fd VoNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=YUD+yROtQGAg2gRUjLOynKW9CQNfydepZgHMrXGgs+E=; b=mK1Pmd/2ezcogAR5WymfUh6eUBzMzH1yrCIJF+P5kawJzifYqzVZzSmbzU3gYHM1mz XlZXBBIGSG7Gapegmk6wRrAKJQL7474Z2rmH4KVIprGv+Q8EPFTxOn4mnGuYzTDvOFM8 DeSkWKwBKqeeuxveGkTDM6KN/AehLL4r16ZBUCqu6qeJ4TalXQLhvNgTQlrjw8Z+xgM8 7TebNfSA+XKk7vX4lWAJU6iKBC5mlQngQa4JHgA060iAMNdixHQMzbwdg5n0sMTwkyt4 cUNQ6EIwAnHVLlNTDSoxeIFpQZK//ov66mL1KYUTQKU7zEEOlJxU7N/DkUTZz7S5pXqY vhqg== X-Gm-Message-State: APjAAAXLVuZF8Rg+Nl+gasPZhM5/j6SV2DfpDFeWKk5WmeeHmf46WsJf LXwMk0TvNBxwkSvb4EhpTDA= X-Google-Smtp-Source: APXvYqwKj4TGt4AbjKRgqDTko05bmibT6V0fhZJR3ReP8o/vt0+XZ5vwxylLO+1G72ycvjXvBUlN+g== X-Received: by 2002:a02:b384:: with SMTP id p4mr50655004jan.125.1562252196971; Thu, 04 Jul 2019 07:56:36 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id l5sm7951295ioq.83.2019.07.04.07.56.35 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 07:56:35 -0700 (PDT) Sender: Mark Johnston Date: Thu, 4 Jul 2019 10:56:31 -0400 From: Mark Johnston To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349423 - head/contrib/elftoolchain/elfcopy Message-ID: <20190704145631.GA63719@raichu> References: <201906261635.x5QGZbJ7051084@repo.freebsd.org> <20190704135649.dsjxkuvj6j25ywdw@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190704135649.dsjxkuvj6j25ywdw@Air-de-Roger> User-Agent: Mutt/1.12.0 (2019-05-25) X-Rspamd-Queue-Id: 8C1E79477F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.949,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jul 2019 14:56:38 -0000 On Thu, Jul 04, 2019 at 03:56:49PM +0200, Roger Pau Monné wrote: > On Wed, Jun 26, 2019 at 04:35:37PM +0000, Mark Johnston wrote: > > Author: markj > > Date: Wed Jun 26 16:35:37 2019 > > New Revision: 349423 > > URL: https://svnweb.freebsd.org/changeset/base/349423 > > > > Log: > > elfcopy: Provide a size hint when creating the section string table. > > > > Use the input file's .shstrtab size as the hint if it exists. This > > gives a small performance improvement when processing files with > > many sections. > > This change breaks the Xen build using objcopy. I have a very simple > test case, pick the file from: > > https://people.freebsd.org/~royger/buildid.ihex > > Then do: > > $ objcopy -I ihex -O binary buildid.ihex buildid.o > objcopy: elf_nextscn failed: Invalid argument > > This used to work before this change, and now fails. Thanks, I posted a patch here: https://reviews.freebsd.org/D20852