From owner-freebsd-hackers@freebsd.org Sat Jan 30 19:04:46 2021 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E71E4F6138 for ; Sat, 30 Jan 2021 19:04:46 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DSkCx3N4Wz3Bsr for ; Sat, 30 Jan 2021 19:04:45 +0000 (UTC) (envelope-from gonzo@bluezbox.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bluezbox.com; s=mail; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N1Yair7MDOokR/71qdoiVLRKtUdCMrZFpQx7vi1Xgpo=; b=bir7KV+jtQ+jXrX+14dii4/M0u lMjkeZXi8z1xCL2Fva0Gr5bjl0mInWXas+fB8EtjN+SasCgilOKa/vIoBmcN7j6wVqOswTLtysnC2 YSRI+FZErZ+CZ7KOzdkLSxf+b4OiHxwb1Pv4sdlcXqO3t3/5A0306Wsrw2N39F+lWUAk=; Received: from localhost ([127.0.0.1] helo=id.bluezbox.com) by id.bluezbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94 (FreeBSD)) (envelope-from ) id 1l5vXx-0002Uw-Bp; Sat, 30 Jan 2021 11:04:37 -0800 Received: (from gonzo@localhost) by id.bluezbox.com (8.15.2/8.15.2/Submit) id 10UJ4aFq009605; Sat, 30 Jan 2021 11:04:36 -0800 (PST) (envelope-from gonzo@bluezbox.com) X-Authentication-Warning: id.bluezbox.com: gonzo set sender to gonzo@bluezbox.com using -f Date: Sat, 30 Jan 2021 11:04:36 -0800 From: Oleksandr Tymoshenko To: Marc Veldman Cc: freebsd-hackers@freebsd.org Subject: Re: Best way to submit patches for -current Message-ID: <20210130190436.GA9142@bluezbox.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD/11.2-RELEASE-p10 (amd64) X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Marc Veldman (marc@bumblingdork.com) wrote: > Hello, > > now that FreeBSD has moved to Git, what is the recommended way to provide patches? > A GitHub or GitLab Merge Request against the FreeBSD main [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Rspamd-Queue-Id: 4DSkCx3N4Wz3Bsr X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bluezbox.com header.s=mail header.b=bir7KV+j; dmarc=none; spf=pass (mx1.freebsd.org: domain of gonzo@bluezbox.com designates 45.55.20.155 as permitted sender) smtp.mailfrom=gonzo@bluezbox.com X-Spamd-Result: default: False [-3.49 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bluezbox.com:s=mail]; FREEFALL_USER(0.00)[gonzo]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[bluezbox.com]; SPAMHAUS_ZRD(0.00)[45.55.20.155:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bluezbox.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.993]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[45.55.20.155:from]; ASN(0.00)[asn:14061, ipnet:45.55.0.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-hackers] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2021 19:04:46 -0000 Marc Veldman (marc@bumblingdork.com) wrote: > Hello, > > now that FreeBSD has moved to Git, what is the recommended way to provide patches? > A GitHub or GitLab Merge Request against the FreeBSD main branch? > Or a (set of) patches generated with git format-patch, the output of gitt diff > Or any other way? Hi Marc, The preferred way to do this is to submit patches to Phabricator[1] I use Arcanist CLI (as described here[2]) to submit/update patches and Web UI to discuss review feedback. Don't forget to add developers to reviewers/Cc list since, unlike bugzilla, there is no general mailing list for new reviewes. If you're not sure who to add, create a review and send URL to a relevant mailing list. [1] https://reviews.freebsd.org/ [2] https://wiki.freebsd.org/Phabricator -- gonzo