From owner-freebsd-fs@freebsd.org Fri Nov 22 23:51:49 2019 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2AA831C4B31; Fri, 22 Nov 2019 23:51:49 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47KY9x0LkFz4P4T; Fri, 22 Nov 2019 23:51:49 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id A87E116772; Fri, 22 Nov 2019 23:51:48 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-lf1-f51.google.com with SMTP id 203so6753782lfa.12; Fri, 22 Nov 2019 15:51:48 -0800 (PST) X-Gm-Message-State: APjAAAVPhmE3PEsJnAS5nTiZ8cOiATy4eHfOAV63gWpWqEWSWfjpVABJ GP2P32yYh7SBWx/BxDrDJ90QVTN98w09OGP2reU= X-Google-Smtp-Source: APXvYqypf9Vc4sq7FzpYE0FNKivOXfcyVY8ONL8hPyNfrYwc9vywAvcIXsYnCdkJaMi+jz0f5LuFpM4Y0GP6Sj8bTo8= X-Received: by 2002:a19:f510:: with SMTP id j16mr61632lfb.30.1574466707181; Fri, 22 Nov 2019 15:51:47 -0800 (PST) MIME-Version: 1.0 References: <1ef80fd8-d695-010f-9dc8-a6b9a2a80f8e@FreeBSD.org> In-Reply-To: From: Matthew Macy Date: Fri, 22 Nov 2019 15:51:35 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Revisiting the ZFS test suite To: Alan Somers Cc: Andriy Gapon , freebsd-testing , freebsd-fs Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2019 23:51:49 -0000 On Wed, Nov 20, 2019 at 8:18 AM Alan Somers wrote: > > On Wed, Nov 20, 2019 at 1:17 AM Andriy Gapon wrote: > > > On 04/10/2019 19:23, Alan Somers wrote: > > > My employment status changed last week, and I find myself once again > > > working on ZFS. It's hard to have confidence in any changes without a > > > solid test suite, so my main task right now is to fix the problems in > > > FreeBSD's ZFS test suite. Our most recent run had 64 failed tests and 99 > > > skipped ones; let's get those down to 0 and something small, > > respectively. > > > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/3880/testReport/ > > > > > > Would anybody be interested to review my changes to the test suite? It's > > > not terrible if I have to commit without review; I can't possibly break > > > anything but the test suite itself. > > > > Alan, > > > > just curious, did you have any plans to merge new tests and changes to > > existing > > tests from illumos or ZoL? > > I've imported quite a few code changes, many times there were test changes > > or > > new test, but I never took time to merge them. > > > > > > -- > > Andriy Gapon > > > > We'll need to do it sooner or later, but it's going to take a large > effort. I can't justify that much effort right now. And it will require > changing ZoL's test suite, too, not just ours. We'll need to convince them > to use ATF, for example. Another issue came up when discussing your mail with Brian - the last release was 2014 and it's no longer available for Linux. -M