From owner-svn-src-all@FreeBSD.ORG Fri Sep 21 05:30:24 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8D2F11065670; Fri, 21 Sep 2012 05:30:24 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 1EA148FC12; Fri, 21 Sep 2012 05:30:24 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 85F808CA; Fri, 21 Sep 2012 07:29:27 +0200 (CEST) Date: Fri, 21 Sep 2012 07:30:43 +0200 From: Pawel Jakub Dawidek To: Baptiste Daroussin Message-ID: <20120921053043.GE1407@garage.freebsd.pl> References: <201209191628.q8JGSckQ025683@svn.freebsd.org> <20120920211701.GD1407@garage.freebsd.pl> <20120920213843.GQ26107@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XuV1QlJbYrcVoo+x" Content-Disposition: inline In-Reply-To: <20120920213843.GQ26107@ithaqua.etoilebsd.net> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r240698 - head/cddl/contrib/opensolaris/cmd/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2012 05:30:24 -0000 --XuV1QlJbYrcVoo+x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 20, 2012 at 11:38:43PM +0200, Baptiste Daroussin wrote: > On Thu, Sep 20, 2012 at 11:17:01PM +0200, Pawel Jakub Dawidek wrote: > > On Wed, Sep 19, 2012 at 04:28:38PM +0000, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Wed Sep 19 16:28:38 2012 > > > New Revision: 240698 > > > URL: http://svn.freebsd.org/changeset/base/240698 > > >=20 > > > Log: > > > Update usage to show the possiblity to use jail name > > > =20 > > > Reported by: bdrewery > > > MFC after: 1 month > > >=20 > > > Modified: > > > head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c > > >=20 > > > Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c Wed Sep 19 16:21= :23 2012 (r240697) > > > +++ head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c Wed Sep 19 16:28= :38 2012 (r240698) > > > @@ -240,9 +240,9 @@ get_usage(zfs_help_t idx) > > > return (gettext("\tupgrade [-v]\n" > > > "\tupgrade [-r] [-V version] <-a | filesystem ...>\n")); > > > case HELP_JAIL: > > > - return (gettext("\tjail \n")); > > > + return (gettext("\tjail \n")); > >=20 > > Please keep the style consistent. As you can see two lines above there > > are spaces around |. > >=20 >=20 > Sure but both syntax are present in the usage: in > fact the only one with space around | is the line above you are showing, = all the > rest of the usage is without space, That is why I did it without spaces. >=20 > If you tell me it is better with spaces, I'll add space. It is probably better to leave it as-is then, I only looked at the diff context. Sorry for the noise. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --XuV1QlJbYrcVoo+x Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBb+4IACgkQForvXbEpPzQEMgCg1tY+3lZ1bJW3Pkad7xY8T6y8 qmEAoPPfoDOkRKwX+nKLdaTGPeUc0Tty =4aL0 -----END PGP SIGNATURE----- --XuV1QlJbYrcVoo+x--