From owner-svn-src-all@freebsd.org Sat Oct 3 07:31:53 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E6CF73FDFA9; Sat, 3 Oct 2020 07:31:53 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C3JTP1qHmz3g8t; Sat, 3 Oct 2020 07:31:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id Oc1Fke1pgTWWpOc1HkspJc; Sat, 03 Oct 2020 01:31:51 -0600 X-Authority-Analysis: v=2.4 cv=EcV2/NqC c=1 sm=1 tr=0 ts=5f7828e7 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=afefHYAZSVUA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=ldZ4Dgq68PpYkNK4kSMA:9 a=DVHuTNj_sjCuzPD8:21 a=8b_37rNafnk_Pw_E:21 a=CjuIK1q_8ugA:10 a=G5htwFfI-ksA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 11F49A42; Sat, 3 Oct 2020 00:31:49 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 0937VmXU026732; Sat, 3 Oct 2020 00:31:48 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202010030731.0937VmXU026732@slippy.cwsent.com> Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jung-uk Kim cc: Cy Schubert , Mateusz Guzik , Emmanuel Vadot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r366381 - head/sys/modules/pwm In-reply-to: <50246694-58eb-0a68-7c9f-309ae2777e08@FreeBSD.org> References: <202010021956.092Jus8I080666@repo.freebsd.org> <202010030412.0934C1Mu015832@slippy.cwsent.com> <50246694-58eb-0a68-7c9f-309ae2777e08@FreeBSD.org> Comments: In-reply-to Jung-uk Kim message dated "Sat, 03 Oct 2020 01:54:48 -0400." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26730.1601710308.1@slippy> Content-Transfer-Encoding: quoted-printable Date: Sat, 03 Oct 2020 00:31:48 -0700 X-CMAE-Envelope: MS4xfEOZ5agDJ2V8QMbeBOXx8gUI+66Gh0Un/A5wetYnvqVvjcwKqd9Q5p23izsmMWT/Q59o/RPm1iqomAEwRu16/RdQR2wSyTHDRX0iWmsRtEsz8604B5fn Sh+gwRDca7e+fPyByxHXpUnT3htJs6oXauJQebSuaCLOdg9FQg8GsHa2A9Qq0eERVe5rQwcTmlsUJ6YphKHHeAAk94NTSTci6YIcwVD0oulnS9R6SfjHeHxD r+oekHOUlKtpey+Ac2aARhgZa2AYG41wKTsfFeF2kbYI4OH4BsnG2piqoqtbOpyFw/22QJ60pV1JYmzSP/LHa3giAvsl8sIfGD20JOwE/UZ8hKosrgb47Ufh QyiNrCvy X-Rspamd-Queue-Id: 4C3JTP1qHmz3g8t X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Oct 2020 07:31:54 -0000 In message <50246694-58eb-0a68-7c9f-309ae2777e08@FreeBSD.org>, Jung-uk Kim= writ es: > > On 20. 10. 3., Cy Schubert wrote: > > In message c > > om> > > , Mateusz Guzik writes: > >> On 10/2/20, Emmanuel Vadot wrote: > >>> Author: manu > >>> Date: Fri Oct 2 19:56:54 2020 > >>> New Revision: 366381 > >>> URL: https://svnweb.freebsd.org/changeset/base/366381 > >>> > >>> Log: > >>> pwm_backlight: Restrict module to armv7 and aarch64 > >>> > >>> Both powerpc64 and riscv uses fdt but don't use EXT_RESOURCES. > >>> > >>> Reported by: jenkins > >>> > >>> Modified: > >>> head/sys/modules/pwm/Makefile > >>> > >>> Modified: head/sys/modules/pwm/Makefile > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D > >> =3D=3D=3D > >>> --- head/sys/modules/pwm/Makefile Fri Oct 2 19:16:06 2020 (r36638 > >> 0) > >>> +++ head/sys/modules/pwm/Makefile Fri Oct 2 19:56:54 2020 (r36638 > >> 1) > >>> @@ -6,8 +6,10 @@ SUBDIR =3D \ > >>> pwmbus \ > >>> pwmc \ > >>> > >>> +.if ${MACHINE_ARCH} =3D=3D "armv7" || ${MACHINE_ARCH} =3D=3D "aarch= 64" > >>> .if !empty(OPT_FDT) > >>> SUBDIR +=3D pwm_backlight > >>> +.endif > >>> .endif > >>> > >>> .include > >> > >> I don't know which commits are to blame, but the following is broken > >> in tinderbox: > >> arm GENERIC kernel failed, check _.arm.GENERIC for details > >> arm GENERIC-NODEBUG kernel failed, check _.arm.GENERIC-NODEBUG for de= tails > >> arm TEGRA124 kernel failed, check _.arm.TEGRA124 for details > >> arm ARMADA38X kernel failed, check _.arm.ARMADA38X for details > >> arm VYBRID kernel failed, check _.arm.VYBRID for details > >> arm GENERIC-MMCCAM kernel failed, check _.arm.GENERIC-MMCCAM for deta= ils > >> arm LINT kernel failed, check _.arm.LINT for details > >> arm IMX53 kernel failed, check _.arm.IMX53 for details > >> arm IMX6 kernel failed, check _.arm.IMX6 for details > >> arm EFIKA_MX kernel failed, check _.arm.EFIKA_MX for details > >> arm ZEDBOARD kernel failed, check _.arm.ZEDBOARD for details > > = > > And on amd64 my laptop is useless now. > > = > > Oct 2 18:23:58 slippy kernel: link_elf_obj: symbol = > > acpi_video_get_backlight_type undefined > > Oct 2 18:23:58 slippy kernel: Warning: memory type debugfsint leaked = > > memory on destroy (2 allocations, 80 bytes leaked). > > Oct 2 18:23:59 slippy kernel: linker_load_file: /boot/modules/i915kms= .ko - > = > > unsupported file type > > = > > And this is also after updating drm-current-kmod. > > Create files directory, add the attached patch there, and try again. > > Jung-uk Kim > > > --- drivers/gpu/drm/i915/display/intel_opregion.c.orig 2020-10-02 18:5 > 0:12 UTC > +++ drivers/gpu/drm/i915/display/intel_opregion.c > @@ -25,6 +25,8 @@ > * > */ > = > +#include > + > #include > #include > #include > @@ -450,10 +452,12 @@ static u32 asle_set_backlight(struct drm_i915_priv= ate = > = > DRM_DEBUG_DRIVER("bclp =3D 0x%08x\n", bclp); > = > +#if __FreeBSD_version < 1300118 > if (acpi_video_get_backlight_type() =3D=3D acpi_backlight_native) { > DRM_DEBUG_KMS("opregion backlight request ignored\n"); > return 0; > } > +#endif > = > if (!(bclp & ASLE_BCLP_VALID)) > return ASLC_BACKLIGHT_FAILED; > This won't work. The machine is already at 1300118. I'll try a #if 0 instead. (I restored a zfs snapshot of /usr/src and /usr/obj.) Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.