From owner-svn-src-all@FreeBSD.ORG  Sun May 23 12:36:19 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 220631065674;
	Sun, 23 May 2010 12:36:19 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id D31F18FC08;
	Sun, 23 May 2010 12:36:18 +0000 (UTC)
Received: from critter.freebsd.dk (critter-phk.freebsd.dk [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 72543900AD;
	Sun, 23 May 2010 12:36:16 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.4/8.14.4) with ESMTP id o4NCaFIa011070;
	Sun, 23 May 2010 12:36:16 GMT (envelope-from phk@critter.freebsd.dk)
To: Bruce Evans <brde@optusnet.com.au>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 23 May 2010 19:01:41 +1000."
	<20100523183502.C13588@delplex.bde.org> 
Date: Sun, 23 May 2010 12:36:15 +0000
Message-ID: <11069.1274618175@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r208332 - in head/sys: amd64/include i386/include 
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 May 2010 12:36:19 -0000

In message <20100523183502.C13588@delplex.bde.org>, Bruce Evans writes:
>On Thu, 20 May 2010, Poul-Henning Kamp wrote:

><machine/atomic.h> should be kernel-only.

No, it absolutely should not, if anything, it should be pushed as
international standards (with <sys/endian.h>, and <sys/queue.h>).

Atomic operations and write barriers are necessary when multiple
threads or processes cooperate using shared memory. and if anything
the bug is that POSIX has not updated pthreads to have these and
other necessary primitives.  (pthread_mutex_assert_held() for instance).

I agree that FlexeLint is a bit hysterical at times, but when the
issue can be avioded at a "cost" of increased clarity of intention,
I don't see any reason to not do so.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.