From owner-svn-src-head@freebsd.org Thu Dec 3 17:03:35 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AD41A3F90B; Thu, 3 Dec 2015 17:03:35 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 550A21DA7; Thu, 3 Dec 2015 17:03:34 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from zeppelin.tachypleus.net (75-101-50-44.static.sonic.net [75.101.50.44]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id tB3H3WNc032044 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 3 Dec 2015 09:03:33 -0800 Subject: Re: svn commit: r291666 - head/libexec/rtld-elf To: Konstantin Belousov References: <201512030006.tB306xTa074887@repo.freebsd.org> <20151203085028.GH2405@kib.kiev.ua> <566062EB.7070200@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Nathan Whitehorn Message-ID: <566075E4.8090202@freebsd.org> Date: Thu, 3 Dec 2015 09:03:32 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <566062EB.7070200@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVagjeNpbLLbB2v0rChELCDGVREbelZumGEKJIsB3lhyE4D+LVVTYj/CgGsJIycp2KupHitduvD6pGOUhHWhUv47JBhc8wJ0704= X-Sonic-ID: C;HFy4yN+Z5RG4VuK7sH9FTg== M;bvHzyN+Z5RG4VuK7sH9FTg== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 17:03:35 -0000 On 12/03/15 07:42, Nathan Whitehorn wrote: > > > On 12/03/15 00:50, Konstantin Belousov wrote: >> On Thu, Dec 03, 2015 at 12:06:59AM +0000, Nathan Whitehorn wrote: >>> Author: nwhitehorn >>> Date: Thu Dec 3 00:06:59 2015 >>> New Revision: 291666 >>> URL: https://svnweb.freebsd.org/changeset/base/291666 >>> >>> Log: >>> Fix build on GCC 5.2 where, at least on PPC64, the compiler would >>> "optimize" >>> the malloc() + memset() in the local implementation of calloc() >>> into a call >>> to calloc(), helpfully turning it into an infinite loop. Clean up >>> some >>> unneeded flags on PPC64 while here. >>> MFC after: 1 month >>> >>> Modified: >>> head/libexec/rtld-elf/Makefile >>> >>> Modified: head/libexec/rtld-elf/Makefile >>> ============================================================================== >>> >>> --- head/libexec/rtld-elf/Makefile Thu Dec 3 00:02:01 2015 >>> (r291665) >>> +++ head/libexec/rtld-elf/Makefile Thu Dec 3 00:06:59 2015 >>> (r291666) >>> @@ -13,7 +13,7 @@ SRCS= rtld_start.S \ >>> malloc.c xmalloc.c debug.c libmap.c >>> MAN= rtld.1 >>> CSTD?= gnu99 >>> -CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD >>> +CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD -fno-builtin >>> CFLAGS+= -I${SRCTOP}/lib/csu/common >>> .if exists(${.CURDIR}/${MACHINE_ARCH}) >>> RTLD_ARCH= ${MACHINE_ARCH} >>> @@ -22,7 +22,6 @@ RTLD_ARCH= ${MACHINE_CPUARCH} >>> .endif >>> CFLAGS+= -I${.CURDIR}/${RTLD_ARCH} -I${.CURDIR} >>> .if ${MACHINE_ARCH} == "powerpc64" >>> -CFLAGS+= -mcall-aixdesc >> I wanted to set -ffreestanding for rtld compilation, but considered >> it only >> a minor issue. Could you test this instead of -fno-builtin, please ? >> > > Sure, I'll test it today. > -Nathan > > -ffreestanding works just as well for this as -fno-builtin. Would you like to make the change? -Nathan