From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Mar 30 03:30:01 2013
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 1901A510
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Sat, 30 Mar 2013 03:30:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id F166FDCB
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Sat, 30 Mar 2013 03:30:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2U3U0Wu022937
 for <freebsd-ports-bugs@freefall.freebsd.org>; Sat, 30 Mar 2013 03:30:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2U3U0q9022936;
 Sat, 30 Mar 2013 03:30:00 GMT (envelope-from gnats)
Resent-Date: Sat, 30 Mar 2013 03:30:00 GMT
Resent-Message-Id: <201303300330.r2U3U0q9022936@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 "r4721@tormail.org" <r4721@tormail.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 774C94FC
 for <freebsd-gnats-submit@FreeBSD.org>; Sat, 30 Mar 2013 03:29:29 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 504B1DC5
 for <freebsd-gnats-submit@FreeBSD.org>; Sat, 30 Mar 2013 03:29:29 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2U3TSAj063345
 for <freebsd-gnats-submit@FreeBSD.org>; Sat, 30 Mar 2013 03:29:28 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r2U3TSTi063344;
 Sat, 30 Mar 2013 03:29:28 GMT (envelope-from nobody)
Message-Id: <201303300329.r2U3TSTi063344@red.freebsd.org>
Date: Sat, 30 Mar 2013 03:29:28 GMT
From: "r4721@tormail.org" <r4721@tormail.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: ports/177491: [patch] fix display of port fail reasons on the
 latest_buildports page
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Mar 2013 03:30:01 -0000


>Number:         177491
>Category:       ports
>Synopsis:       [patch] fix display of port fail reasons on the latest_buildports page
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 30 03:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     r4721@tormail.org
>Release:        
>Organization:
>Environment:
>Description:
a missing echo causes the port fail reason to not be displayed on the latest_buildports page.

this patch has also been sent to the software vendor.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: ports-mgmt/tinderbox/files/patch-fail-reasons
===================================================================
--- ports-mgmt/tinderbox/files/patch-fail-reasons	(revision 0)
+++ ports-mgmt/tinderbox/files/patch-fail-reasons	(working copy)
@@ -0,0 +1,11 @@
+--- webui/templates/default/latest_buildports.tpl.orig
++++ webui/templates/default/latest_buildports.tpl
+@@ -50,7 +50,7 @@
+ 				<?php $reason=$row['port_last_fail_reason']?>
+ 				<td class="<?php if(!empty($port_fail_reasons[$reason]['type']))echo "fail_reason_".$port_fail_reasons[$reason]['type']?>">
+ 				<?php $href=isset($port_fail_reasons[$reason]['link']) ? "index.php?action=display_failure_reasons&amp;failure_reason_tag=$reason#$reason" : "#"?>
+-				<a href="<?php echo $href?>" class="<?php if(!empty($port_fail_reasons[$reason]['type']))echo "fail_reason_".$port_fail_reasons[$reason]['type']?>" title="<?php if(!empty($port_fail_reasons[$reason]['descr']))echo $port_fail_reasons[$reason]['descr']?>"><?php $reason?></a>
++				<a href="<?php echo $href?>" class="<?php if(!empty($port_fail_reasons[$reason]['type']))echo "fail_reason_".$port_fail_reasons[$reason]['type']?>" title="<?php if(!empty($port_fail_reasons[$reason]['descr']))echo $port_fail_reasons[$reason]['descr']?>"><?php echo $reason?></a>
+ 				</td>
+ 				<td>
+ 					<?php if($row['port_link_logfile']){?>


>Release-Note:
>Audit-Trail:
>Unformatted: