From owner-svn-src-head@freebsd.org Sun Nov 5 05:50:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5B30E62EBF for ; Sun, 5 Nov 2017 05:50:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A16806ED97 for ; Sun, 5 Nov 2017 05:50:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22b.google.com with SMTP id p186so12509238ioe.12 for ; Sat, 04 Nov 2017 22:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=CBl5yK/pGBbJL6fLFLuk0KmPDW1Q9wLNBZq5bwB695Y=; b=2EnD3qFaRvbR/44gqQc+S1Lddth6YuCpjAQfrKeykpu4wcIhu+7Disx+NegJQdq6Dz xXuEjP13UUq55JUGkP/4TiYDlIu7RSUaSypwPeukDo8r2wTCi6sC7Ss6MKBrIOSaDlU/ +3foOn33GFd3hOQq4MW7GYD2pAOY+zvGzT+rKn+Sr8VPxpOAEtj/ihDvHLr9ccjqILmU eF0sf0gFBh75OhSB03vPxSvudBfHwgptOZXeM5YMob6rbr9ngtgqzVsgnpYrYBL5DRz8 r7iqFMix6G3gXMpMU4ZjeYGk8Y33h4EQlYckpLIxsStOPH+2VtWPBHnFhjbykhhS0F7+ eS2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=CBl5yK/pGBbJL6fLFLuk0KmPDW1Q9wLNBZq5bwB695Y=; b=EajmWMsVjh/ESQ2SAXrn7Tf4PBP9q/U6MgTODxdNbstgrl2/1e8qwNOtwLWQBXd9d+ iGjXtZCPgu6Ih6PJ4ZKrEsFK3+19unZpwb905+mgoo8cwPAQIGWKT+Iu5M4xSKiphPxz 2KLfXL5z0rNGdp52FsTtBAquL3h6WMRBh9LCcITWQvVVF0ohKVLuieoTU0IfDEuQf3jE cu8Amh12LdSVPPjfYyJLYz4IcFkJf8gSjZdtc0KHdVm1331m+5Q4s3nnl7O+thKcBhZD WEE4KhUQO2Et2p+liT6VLw5eDKnvPevsInG3kpY7J8mOZVufI72Nty+bpUSf2OBphWY3 ZenQ== X-Gm-Message-State: AJaThX4yWRahPT849sx/A1IKUDMWVcD/2bm++lJbq7f8h67ZnGA+Zeqg QdHwhoM5jQeW5rJkiD64N6jBy5q0VUa3J4IxgH80zg== X-Google-Smtp-Source: ABhQp+TU0baa2qid8Bda75O3pDi6dV4cl3HcJHYjY/Y+ujlw8OJbWQ6FY8F29RkTLcEUNtTWykt33Fefa9RciSot/xU= X-Received: by 10.107.81.21 with SMTP id f21mr14765126iob.63.1509861000043; Sat, 04 Nov 2017 22:50:00 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Sat, 4 Nov 2017 22:49:59 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:a004:68c9:b567:b3a8] In-Reply-To: <57DE6BAA-EAE4-49EB-BEEE-27286480B283@gmail.com> References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> <3a0a92dd-19fc-2ee3-dcbf-224e4c2e8eec@FreeBSD.org> <57DE6BAA-EAE4-49EB-BEEE-27286480B283@gmail.com> From: Warner Losh Date: Sat, 4 Nov 2017 23:49:59 -0600 X-Google-Sender-Auth: 4B2OU6YL3owoybQ7o4l6dCwpy90 Message-ID: Subject: Re: svn commit: r325116 - head To: "Ngie Cooper (yaneurabeya)" Cc: Bryan Drewery , Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 05:50:01 -0000 On Sat, Nov 4, 2017 at 11:30 PM, Ngie Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > > > On Nov 4, 2017, at 08:31, Bryan Drewery wrote: > > > > On 11/4/2017 12:08 AM, Ngie Cooper (yaneurabeya) wrote: > >> I just ran into this with bash on universe12a.freebsd.org by > doing ^d. I think the change should be reverted. > >> Thanks, > >> -Ngie > >> > >> $ exit > >> *** Error code 130 > >> > >> Stop. > >> make[1]: stopped in /scratch/tmp/ngie/svn > >> *** Error code 1 > >> > >> Stop. > >> make: stopped in /scratch/tmp/ngie/svn > >> > > > > When you first go into buildenv check 'echo $?'. > > My problem was a construct like '[ -f xxx ] && . xxx' at the end of one > > of my profile scripts. It needs to be 'if [ -f xxx ]; then . xxx; fi' > > to avoid the bad status. It's really unrelated to buildenv. > > The last line in my ~/.bashrc on my VM is export PATH that doesn=E2=80=99= t fail > with a syntax error, and the last line on my ~/.bashrc on universe12a is = an > alias set, which also doesn=E2=80=99t fail with a syntax error. Both case= s set $? =3D > 0. > > The issue I reported is caused by doing ^c + ^d (hence the error code 130 > in my original reply). I guess this is expected, but it=E2=80=99s going t= o confuse > people and force them to have to investigate the issue, unnecessarily, wh= en > it wasn=E2=80=99t an =E2=80=9Cissue=E2=80=9D before. > I can confirm this in my rather bare-bones bash environment. I'm inclined to think that the edge case like this throwing slightly odd results is a less bad outcome than not being able to get the results of a make buildenv command... It's good to know that this oddity can happen. We could: (a) just put "|| true" back and stop. This breaks detecting if the make buildenv command failed. (b) We could just document this can happen, which is easy but still has the issue (c) We could create a new target to run commands, but that would be exactly what buildenv is w/o the || true. I'm inclined do (b). (a) is a non-starter. (c) is possible, but seems wasteful to solve this case that can be explained in documentation. Warner