From owner-svn-src-head@freebsd.org Mon Dec 10 05:22:57 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 000F61312100; Mon, 10 Dec 2018 05:22:56 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 09AE58EB4A; Mon, 10 Dec 2018 05:22:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id WDzKgpqkkyqMYWDzMgfaCc; Sun, 09 Dec 2018 22:20:18 -0700 X-Authority-Analysis: v=2.3 cv=CvFujUwD c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=2ur7OfE09M0A:10 a=xfDLHkLGAAAA:8 a=ypVJL4-jAAAA:8 a=7Qk2ozbKAAAA:8 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=oR3WUjlfROKjby8XLScA:9 a=CjuIK1q_8ugA:10 a=IfaqVvZgccqrtc8gcwf2:22 a=khIbc0fXALFIcTpOSxgJ:22 a=1lyxoWkJIXJV6VJUPhuM:22 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 8EC681E56; Sun, 9 Dec 2018 21:20:14 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id wBA5KE8E036425; Sun, 9 Dec 2018 21:20:14 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id wBA5KD8o036422; Sun, 9 Dec 2018 21:20:13 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201812100520.wBA5KD8o036422@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: Oliver Pinter , "Rodney W. Grimes" , svn-src-head@freebsd.org, Cy Schubert , svn-src-all@freebsd.org, src-committers , Cy Schubert Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... In-Reply-To: Message from Warner Losh of "Sun, 09 Dec 2018 14:24:07 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 09 Dec 2018 21:20:13 -0800 X-CMAE-Envelope: MS4wfDkNsKEla0MnVP2J6z8SZOMiz1bhND8jsNOlS2WZXqlpqbi6DxaOhBYKV2JA+T4yFSuW/hCVCq6s/9tZ/bmfiL6jRpHGL/OpZprxqTScu7aTT1gVU5zq rSQ5Q6XoL1WJV+e5qkt9hGwPt+WZLFylJPwdkMs+cZlUvgFS8LtfjU65smL+FKX/aZIbk7pXSi1GHpSafLeh/frg7wxrwC89rPYVPVaruDChiTVVPgB4+n04 n0cvozMmhKkXWI+sBoTW0w8DW3hszQoOR1IpKZRnfCvojRvyCRajA5E0iyPHPejZEfbFU3qqJMaFDfwHArdEA807O7gnq7+QgCrwD+h8GMgUWpWdN5NI0wH7 jCUjuaOOes7KgyuiB9f3FJQiWo+DpA== X-Rspamd-Queue-Id: 09AE58EB4A X-Spamd-Result: default: False [-2.88 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_IN_DNSWL_LOW(-0.10)[138.136.59.64.list.dnswl.org : 127.0.5.1]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; LONG_SUBJ(1.52)[203]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; REPLYTO_EQ_FROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_SHORT(-0.77)[-0.767,0]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; IP_SCORE(-1.93)[ip: (-4.36), ipnet: 64.59.128.0/20(-2.88), asn: 6327(-2.30), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 05:22:57 -0000 In message , Warner Losh writes: > --0000000000009ed486057c9d7878 > Content-Type: text/plain; charset="UTF-8" > > On Sun, Dec 9, 2018 at 2:03 PM Oliver Pinter > wrote: > > > > > > > On Sunday, December 9, 2018, Warner Losh wrote: > > > >> On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < > >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> > >> > > In message <201812090645.wB96jnso066329@repo.freebsd.org>, Cy > >> Schubert > >> > > writes: > >> > > > Author: cy > >> > > > Date: Sun Dec 9 06:45:49 2018 > >> > > > New Revision: 341759 > >> > > > URL: https://svnweb.freebsd.org/changeset/base/341759 > >> > > > > >> > > > Log: > >> > > > MFV r341618: > >> > > > > >> > > > Update wpa 2.6 --> 2.7. > >> > > > >> > > Relnotes: yes > >> > > >> > As an FYI, or maybe a new procedure, doing a reply to > >> > a commit message adding relnotes: yes does very little > >> > to insure that this commit gets refered to in release > >> > notes. > >> > > >> > What about we add RELNOTES.missed to the tree > >> > next to UPDATING, and when someone forgets to tag > >> > the Relnotes:yes into a commit you just follow up > >> > with a commit to that file, stating the svn revision > >> > which was missing the note and then we have a nice > >> > documented and clean way to extract the missing > >> > release note items, rather than trying to cull it > >> > from a thread in a mail list archive. > >> > > >> > The file would get truncated to 0 at appropriate > >> > times on various branches. > >> > > >> > >> How about just RELNOTES. You put the revision that is relevant and a quick > >> blurb. That way we don't have to look in two places. All release notes go > >> in here, no exceptions. You can retroactively tag them, or you can commit > >> this as part of commit. > > > > > >> > > I don't really know SVN, but there wouldn't be a chicken egg probem during > > commit time? I mean you would really know the SVN id. So you could only add > > a specific revision in a different commit to RELEASE file. > > > > Generally, you can guess really well, and fix it in the case of a lost race > easily. > > You'd add the release notes text in full to the file, with a pointer to the > revision(s) for the feature. How about a couple of other alternatives? Hmmm. Rather than bloat the repo, can we put this onto wiki.freebsd.org? Downside, people tend to forget or it's too much of a hassle. Upside, no repo bloat. OTOH, if it is to be a file, IMO it should live in the doc repo. If people write up good notes they can be included directly from doc/. Personally, I prefer "put it in the doc repo" better. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.