From owner-svn-src-all@FreeBSD.ORG Fri Mar 27 16:01:17 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 172E0106566B; Fri, 27 Mar 2009 16:01:17 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id DDDDA8FC24; Fri, 27 Mar 2009 16:01:16 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n2RG1GVC062516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Mar 2009 09:01:16 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <49CCF84C.2030409@freebsd.org> Date: Fri, 27 Mar 2009 09:01:16 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Juli Mallett References: <200903270544.n2R5irsu049333@svn.freebsd.org> In-Reply-To: <200903270544.n2R5irsu049333@svn.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190462 - head/sys/dev/wpi X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2009 16:01:17 -0000 Juli Mallett wrote: > Author: jmallett > Date: Fri Mar 27 05:44:53 2009 > New Revision: 190462 > URL: http://svn.freebsd.org/changeset/base/190462 > > Log: > Put the "%d retries" debug message in the transmit path behind WPI_DEBUG_TX > rather than behind a seemingly accidental constant likely left over from one of > the related drivers which uses log levels rather than per-facility debugging > flags. This should get rid of contextless messages on the console for people > who have not set (or cleared the default) debugging flags. > > Modified: > head/sys/dev/wpi/if_wpi.c > > Modified: head/sys/dev/wpi/if_wpi.c > ============================================================================== > --- head/sys/dev/wpi/if_wpi.c Fri Mar 27 05:35:12 2009 (r190461) > +++ head/sys/dev/wpi/if_wpi.c Fri Mar 27 05:44:53 2009 (r190462) > @@ -1587,7 +1587,7 @@ wpi_tx_intr(struct wpi_softc *sc, struct > */ > wn->amn.amn_txcnt++; > if (stat->ntries > 0) { > - DPRINTFN(3, ("%d retries\n", stat->ntries)); > + DPRINTFN(WPI_DEBUG_TX, ("%d retries\n", stat->ntries)); > wn->amn.amn_retrycnt++; > } > > wlan_amrr has macros to replace all the direct frobbing of data structures and also it's own debug messages that are enabled with wlandebug rate. Might be worth cleaning up the driver (and might also improve performance if my reading of the code is right). Sam