From owner-svn-src-head@FreeBSD.ORG Fri Sep 19 22:42:14 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8F27F67; Fri, 19 Sep 2014 22:42:14 +0000 (UTC) Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35]) by mx1.freebsd.org (Postfix) with ESMTP id A988D5FD; Fri, 19 Sep 2014 22:42:14 +0000 (UTC) Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534) id 8737C20E7088E; Fri, 19 Sep 2014 22:42:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.multiplay.co.uk X-Spam-Level: ** X-Spam-Status: No, score=2.2 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX, FSL_HELO_NON_FQDN_1,RDNS_DYNAMIC,STOX_REPLY_TYPE autolearn=no version=3.3.1 Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170]) by smtp1.multiplay.co.uk (Postfix) with ESMTPS id E15F220E7088A; Fri, 19 Sep 2014 22:42:09 +0000 (UTC) Message-ID: <22388302B2EF4C53B49F0541ABDB3198@multiplay.co.uk> From: "Steven Hartland" To: "Will Andrews" , "John Baldwin" References: <201409181655.s8IGtgft042984@svn.freebsd.org><5783417ED470465B9C816FCA02B3690D@multiplay.co.uk><11362806.9nSfhFyLDg@ralph.baldwin.cx> Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Date: Fri, 19 Sep 2014 23:42:03 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "src-committers@FreeBSD.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 22:42:15 -0000 ----- Original Message ----- From: "Will Andrews" To: "John Baldwin" Cc: "Steven Hartland" ; "src-committers@FreeBSD.org" ; ; Sent: Friday, September 19, 2014 6:35 PM Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs >I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this > particular implementation of the tunable, so there is a regression > that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no > matter what's in loader.conf). I believe it's limited to this > particular tunable, however, because I tested another SYSCTL_PROC that > had CTLFLAG_TUN set and it worked. Given I pointed you in this direction I kinda felt guilty that you where having issues so had a dig. It took quite a few printf's and a reboots but I found the cause. The name of your sysctl is conflicting with the 4th loader which believes your vfs.zfs.debug_flags is a module _flags setting as it matches the reserved suffix *_flags as detailed in loader.conf (5). I think the loader should only consider [a-z0-9_]+_flags as module flags as I can't see any modules having any other chars expecially not "." in their name; but I've no idea how to do that in 4th. So the fix is to rename you sysctl e.g. vfs.zfs.debugflags. Hope this helps. Regards Steve