From nobody Sun Jul 19 18:50:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h3CQf1PvKz6lQtS for ; Sun, 19 Jul 2026 18:50:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h3CQd6M2fz3RD9 for ; Sun, 19 Jul 2026 18:50:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784487049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/rzxQarAZJkxgC7eNIG8AN6jsgBC5BwuH2PIn1yEqf8=; b=RT6owXX+oGtgjsSpQP6mmcRv//wghBCfdW9Hxw8DZurRUYJLUjj8mxm20pn5KOTAUwRzJX 57oGyJg8jFHIHmzXIfU8fZAufGbfINrLCd645caorFjDPxXKvDyezZ99kjtItPtAK+dAfv cZ6csMHS2qPoQX/F8xEkkmSq+XJ/gel2hMc039BB+fhXYuBZ29NqycNpi2Fv7OPuT+fupe eldNPEd2C9ER/cbw5BwoefJTsAYncVkMByRhbEHHt0OrQPVUz4GXIb6puI6MV+/4XLRfoF uEviS9yxpJ30dNjf7ts4TpIJ0XjYPzwEBC/pE/wQIy77TziGmbXDW4fnkYuc/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784487049; a=rsa-sha256; cv=none; b=uXzEjl4s21VChd34R0WDQuhUGgC35Bf0W0CTZaTvriMgCB6AEO4fWRZ63P14Yk6cR4vtI7 qODeX/Z38n0/DHMKY8XqdLYyUYj1HuR4j0RMQ6tVUdByUEGr4uuaS2rN6tdCvCZVeWsGky jlBYJ2XHiPG2aWm6qUI77r/BVOY00yjN18j8vle42pah/Mjmg8BkZbi4sE9yLijbItIhhL DJgZ6h+/Q+O6nEBhE3Ab4sQXs0SBkyAGGpIk1iBGoyhxSFr1UuJMXH7uMaWFHcjq7fyZLo jQg/yU18v37sQKVlIyro3eObbQrijpc3eRZa+2M9eGdYG+dJNcdr51vwhmuz4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784487049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/rzxQarAZJkxgC7eNIG8AN6jsgBC5BwuH2PIn1yEqf8=; b=uz8bWcaj37BfJK2jn3tSSJ3WN8ZSLqQOWRnsV45pfcfiNRo5jnj7FE2ZxztTT7oeKHjMs1 65C3Tf0cIs9RY25N8eWzRjj732iIahUm6XMVi9wtxhYY9yN/42Rnzv8w2Z/13QMF4mr5Tq RWQ0EACX5thPHz/TqkeoM0Ko6kRpG0r7dUJnwV6qFetandK8jeZ5RyzK+deQNLUWs2ax3t 1Li3rMwvIq3JL5dFw0ETCQZhIRT/Ywe1fAEx5Bw/rG4BebzobT1IgEHyANDgFE73SwUvQ7 JEKdc3I9C976fECWxD7yUKT2yCWmShC0Gud9+BvEJkCowfn2nmMrMmEJM9QD0Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h3CQd4JX7zBrK for ; Sun, 19 Jul 2026 18:50:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e1f4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 19 Jul 2026 18:50:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: =?utf-8?Q?J=C3=A9r=C3=A9mie?= Jourdin From: Adrian Chadd Subject: git: 4bff6b9f5cef - main - re(4): re-arm the Tx doorbell when re_txeof() leaves a non-empty ring List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4bff6b9f5cef13df8540fa6869bd6707f8e7575d Auto-Submitted: auto-generated Date: Sun, 19 Jul 2026 18:50:49 +0000 Message-Id: <6a5d1c89.3e1f4.2470105a@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=4bff6b9f5cef13df8540fa6869bd6707f8e7575d commit 4bff6b9f5cef13df8540fa6869bd6707f8e7575d Author: Jérémie Jourdin AuthorDate: 2026-07-19 18:42:22 +0000 Commit: Adrian Chadd CommitDate: 2026-07-19 18:45:15 +0000 re(4): re-arm the Tx doorbell when re_txeof() leaves a non-empty ring On PCIe parts a TxPoll request can be lost when packets are queued in quick succession, leaving owned descriptors with no transfer in progress until the watchdog fires. re_txeof() runs from the interrupt handlers, re_tick() and re_watchdog(), so re-writing TXSTART whenever the ring is still non-empty turns a potential 5-second stall into at most one tick. One register write on a path that already took an interrupt; fast path untouched. * Sustained bidirectional load on RTL8168H; no Tx stalls, no throughput regression at 941 Mbps line rate. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D58277 PR: kern/166724 --- sys/dev/re/if_re.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sys/dev/re/if_re.c b/sys/dev/re/if_re.c index cf7ba90c9a5a..4df75474bce3 100644 --- a/sys/dev/re/if_re.c +++ b/sys/dev/re/if_re.c @@ -2464,6 +2464,17 @@ re_txeof(struct rl_softc *sc) /* No changes made to the TX ring, so no flush needed */ if (sc->rl_ldata.rl_tx_free != sc->rl_ldata.rl_tx_desc_cnt) { + /* + * Some descriptors are still owned by the controller. On PCIe + * parts a TxPoll request can be lost when Tx packets are queued + * too close together, leaving a non-empty ring with no transfer + * in progress. Re-arm the transmitter here -- this routine is + * reached from the interrupt handlers, re_tick() and + * re_watchdog() -- so a lost poll cannot stall the ring until + * the watchdog fires. + */ + if ((sc->rl_flags & RL_FLAG_PCIE) != 0) + CSR_WRITE_1(sc, sc->rl_txstart, RL_TXSTART_START); #ifdef RE_TX_MODERATION /* * If not all descriptors have been reaped yet, reload