From owner-svn-src-all@FreeBSD.ORG Fri Jun 1 01:29:07 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id AA9C6106564A; Fri, 1 Jun 2012 01:29:07 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 3ABBD153CD8; Fri, 1 Jun 2012 01:29:07 +0000 (UTC) Message-ID: <4FC81AE3.10304@FreeBSD.org> Date: Thu, 31 May 2012 18:29:07 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Tom Judge References: <201205311933.q4VJXpnE060290@svn.freebsd.org> In-Reply-To: <201205311933.q4VJXpnE060290@svn.freebsd.org> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler Subject: Re: svn commit: r236362 - head/share/misc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2012 01:29:07 -0000 On 5/31/2012 12:33 PM, Tom Judge wrote: > - Sort the node list while I'm here. This falls under the category of a "whitespace" change, which should have been done as a separate commit (usually first, then substantive changes second). This is a tiny bit more work for you, but down the road when someone who is !tj is reviewing the logs, diffs, etc. it really helps to make the substantive changes stand out. Doug -- This .signature sanitized for your protection