From nobody Fri Apr 24 07:48:33 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g24p93KNJz6ZhyH for ; Fri, 24 Apr 2026 07:48:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g24p92g0mz483c for ; Fri, 24 Apr 2026 07:48:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777016913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A1OelZ2uactqx5Pq4XrSFUNOW21WIIIUS793DmSY9vo=; b=AjdjZX/J4vCZAuX6/f/L+MP9prqhOI0o8MMrQ9bpNdFnb3znpoEcdzs6WTiN7F9F0PQJJ7 gk95PhU8MTwux7KVDcyhiYZjl2P0bsrnqnYxv2x/YDhuwX1mH/FkO0DIHm68hLm+s61Si3 0YFiqMA3nxJReJsYNxZDD0O2NAU4cLSF/OaDTijAZWuSFQUZ7s1WzeThVE1NnJ3Clil6Y4 ALX1Nx83KYc5o6s/laqTF66kZKbaKwwv5Y8uoUAOisIX1hVAJ/vMW7e+NmgOS5zgLRlJHM qje1uy67q4QBeZU+OOgKQG30ohs7/IYMH/Z4xweT+E5Hg+ZQCs3m1HcJMFxMlQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777016913; a=rsa-sha256; cv=none; b=NPxE6dQbjbablmvg+efYL3+XmOvPDQy8K3l5AcQ0OdAsv5c7tUdZe3HfZvCjmTKaUt+8TL RmPPaOIj7i2+wQY2P1S+yAk4b/nWkPQRV7qmlntbZVz/9o80IuqLXj7/yJ3S267ewZOR/k UiarVoXjT1VzwVukwDD4zPgiGNJndvhg+SgqUZNKUDqOGz3u05rqaWdeEk7H5RnUjtbM8M bfQgKZy3NC4dCtAz9xpYFwcShVI9EoxH/MsLWaakXG2IZO49A2Hm1CWathyjucYjCPqa9z 3Sv8RqJnSITLLdI2DF3XA2b51GOFP2euxNSQvMQikJ6LS49/vF58+Ye5lyYGMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777016913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A1OelZ2uactqx5Pq4XrSFUNOW21WIIIUS793DmSY9vo=; b=rqq3eQIIIfY0f0xc49b3lNtf8dgDuXZZRALtu8SvJ6BZJNmEDENCYz1czIMtmSqx/qHn0+ EG4fg8zKL2a237v6nlJ9w7hnp1iTGoJl2PVu8l+7goOaruDtuT19oqv4AOarorNw7HmEsr BzbGEyiHtH4vM1t8Ni9vSHSZdtw8RpQ45COs3kOfG5iCXYU9M/qQKnUpnlNw6iGpy3RfRS HKxMk3PBsK0ahuL/Q4f2ZPSbJGo/nhMl2Ea39WLeydkFzVdo18sFuNEZWGUjpwgO+b9ABL rThyoTYZoX3kvAVTeZo8i/qglTXhDIitKfV07yFX8kZQXxQj5bsTlFQa7d13Mw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g24p91sNmztYP for ; Fri, 24 Apr 2026 07:48:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24b9f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 07:48:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Johan=?utf-8?Q? S=C3=B6llv?=ander Subject: git: eb837cb8b207 - main - ctld: normalize iSCSI TargetName on login List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: js X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: eb837cb8b2073c09bafaf3318f5bb103827b2bca Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 07:48:33 +0000 Message-Id: <69eb2051.24b9f.e879694@gitrepo.freebsd.org> The branch main has been updated by js: URL: https://cgit.FreeBSD.org/src/commit/?id=eb837cb8b2073c09bafaf3318f5bb103827b2bca commit eb837cb8b2073c09bafaf3318f5bb103827b2bca Author: Johan Söllvander AuthorDate: 2026-04-24 07:44:43 +0000 Commit: Johan Söllvander CommitDate: 2026-04-24 07:44:43 +0000 ctld: normalize iSCSI TargetName on login Case-insensitive TargetName matching on logins was accidentally removed, let's fix that by normalizing TargetName again according to RFC 3722. PR: 294522 Fixes: 4b1aac931465f39c5c26bfa1d5539a428d340f20 Sponsored by: ConnectWise MFC after: 1 week Reviewed by: asomers, jhb Approved by: asomers (mentor) Differential Revision: https://reviews.freebsd.org/D56469 --- usr.sbin/ctld/login.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/login.cc b/usr.sbin/ctld/login.cc index cda11cc1f21b..fb4b60c37f54 100644 --- a/usr.sbin/ctld/login.cc +++ b/usr.sbin/ctld/login.cc @@ -967,12 +967,18 @@ iscsi_connection::login() login_send_error(request, 0x02, 0x07); log_errx(1, "received Login PDU without TargetName"); } + /* + * Normalize target_name according to RFC 3722 + */ + std::string t_name(target_name); + for (char &c : t_name) + c = tolower(c); - conn_port = pg->find_port(target_name); + conn_port = pg->find_port(t_name); if (conn_port == NULL) { login_send_error(request, 0x02, 0x03); log_errx(1, "requested target \"%s\" not found", - target_name); + t_name.c_str()); } conn_target = conn_port->target(); }