From owner-cvs-all Sun Sep 16 21: 7:19 2001 Delivered-To: cvs-all@freebsd.org Received: from mass.dis.org (mass.dis.org [216.240.45.41]) by hub.freebsd.org (Postfix) with ESMTP id A50CF37B406; Sun, 16 Sep 2001 21:07:08 -0700 (PDT) Received: from mass.dis.org (localhost [127.0.0.1]) by mass.dis.org (8.11.6/8.11.3) with ESMTP id f8H4EjT04539; Sun, 16 Sep 2001 21:14:47 -0700 (PDT) (envelope-from msmith@mass.dis.org) Message-Id: <200109170414.f8H4EjT04539@mass.dis.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Mitsuru IWASAKI Cc: msmith@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c In-reply-to: Your message of "Mon, 17 Sep 2001 11:51:13 +0900." <20010917.115113.07647289.iwasaki@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 16 Sep 2001 21:14:45 -0700 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > Revision Changes Path > > 1.39 +11 -1 src/sys/dev/acpica/acpi.c > > It seems that this change breaks non-ACPI_TYPE_DEVICE device probing > such as acpi_tz (see nsxfname.c:AcpiGetObjectInfo()). > How about the following patch? > # or we need to fix acpi_DeviceIsPresent() acpi_DeviceIsPresent() should really only be called on devices; I think the patch below is correct. Can you commit it? I will be away from a computer for the next 24 or so hours... > > Index: acpi.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v > retrieving revision 1.39 > diff -u -r1.39 acpi.c > --- acpi.c 15 Sep 2001 04:14:31 -0000 1.39 > +++ acpi.c 17 Sep 2001 02:14:22 -0000 > @@ -790,7 +790,7 @@ > * leave it disabled (so that we have a device_t attached to > * the handle, but we don't probe it). > */ > - if (!acpi_DeviceIsPresent(child)) { > + if ((type == ACPI_TYPE_DEVICE) && (!acpi_DeviceIsPresent(child))) { > device_disable(child); > break; > } > -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message