From owner-cvs-all Mon Dec 18 5:31:17 2000 From owner-cvs-all@FreeBSD.ORG Mon Dec 18 05:31:13 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from assaris.sics.se (assaris.sics.se [193.10.66.234]) by hub.freebsd.org (Postfix) with ESMTP id 47A0137B400; Mon, 18 Dec 2000 05:31:12 -0800 (PST) Received: (from assar@localhost) by assaris.sics.se (8.9.3/8.9.3) id OAA77207; Mon, 18 Dec 2000 14:31:21 +0100 (CET) (envelope-from assar) Sender: assar@assaris.sics.se From: Assar Westerlund To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern strlcat.c strlcpy.c src/sys/sys libkern.h src/sys/conf files References: <200012180408.eBI48wg99879@freefall.freebsd.org> Date: 18 Dec 2000 14:31:21 +0100 In-Reply-To: Dag-Erling Smorgrav's message of "18 Dec 2000 11:39:54 +0100" Message-ID: <5l66khluty.fsf@assaris.sics.se> Lines: 35 User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.6 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Dag-Erling Smorgrav writes: > Assar Westerlund writes: > > Log: > > add strlcpy and strlcat to kernel > > Please back this out backed out. > and think about how you can implement strlcat() and strlcpy() in > much less code Is that really something worth optimizing? And isn't it worth something having the same implementation of these functions as in libc? > and avoid duplicating strcat() and strcpy(), as I already pointed > out on -arch. static __inline char * strcat(char *dst, const char *src) { return (strlcat(dst, src, UINT_MAX)); } static __inline char * strcpy(char *dst, const char *dst) { return (strlcpy(dst, src, UINT_MAX)); } But that's an API change for kernel modules and something that should be decided on doing before burning the bring. /assar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message