From owner-freebsd-net@FreeBSD.ORG Fri Mar 21 18:47:25 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AAAAC79D; Fri, 21 Mar 2014 18:47:25 +0000 (UTC) Received: from mail-ee0-x22c.google.com (mail-ee0-x22c.google.com [IPv6:2a00:1450:4013:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1DE9118C; Fri, 21 Mar 2014 18:47:24 +0000 (UTC) Received: by mail-ee0-f44.google.com with SMTP id e49so2125547eek.17 for ; Fri, 21 Mar 2014 11:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=2RLvp/1HK5/5NsgIxzzTS0H284SXDTqOGc5tknKm8vU=; b=zP0niGnhXSLzGkw6BvMT08JuDpPrmJX9qJFju/GkOp2ylfANy95PMMCxytz6emz7Ae uFLZi9vNLv763D/Az1yc88XndNnjMjDUbBi9MQTfrl1du0I5Lh3XiNxcogMNUK4rXhpW 5b48A2BsN/hcTijGsirahnnDv4jBBNAEpWtNErdDUV+CprJSkh4Hc0ru/47ZeY94vkDR GHkVLhcrHi/Qyk2CnDaavpZlFrEMBZe+yZFgZUG9mn1xkfrK6SUA5Vd7ZfIau9uxhaYK XQOwMyI2Fwz2/AY30vUcyUIeEUq56j7Orob3gnkKE+YR+4STSBoSe2CgOCAbmsFyyhCT i5Rg== MIME-Version: 1.0 X-Received: by 10.15.31.70 with SMTP id x46mr2591427eeu.26.1395427642639; Fri, 21 Mar 2014 11:47:22 -0700 (PDT) Received: by 10.14.219.68 with HTTP; Fri, 21 Mar 2014 11:47:22 -0700 (PDT) In-Reply-To: <20140319163544.GB11935@ox> References: <532933A3.4030403@freebsd.org> <20140319163544.GB11935@ox> Date: Fri, 21 Mar 2014 18:47:22 +0000 Message-ID: Subject: Re: Include port number in "Listen queue overflow" messages From: hiren panchasara To: Julian Elischer , George Neville-Neil , hiren panchasara , "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Mar 2014 18:47:25 -0000 On Wed, Mar 19, 2014 at 4:35 PM, Navdeep Parhar wrote: > On Tue, Mar 18, 2014 at 11:05:23PM -0700, Julian Elischer wrote: >> On 3/18/14, 8:33 PM, George Neville-Neil wrote: >> >On Mar 7, 2014, at 1:23 , hiren panchasara wrote: >> > >> >>I am thinking of committing following change that includes port number >> >>in "Listen queue overflow" messages. >> I think it's a good idea. There is even more information available >> but this is probably enough. >> >> >> >I like it. >> > >> >Best, >> >George >> > > > I think the suggested change isn't correct as is assumes every socket's pcb is > an inpcb. You are right. I'd need to think a bit more about a possible solution. Thanks for your help. cheers, Hiren > > Navdeep > >> >>New message would look something like: >> >>sonewconn: pcb 0xfffff8001b155760: Listen queue overflow on port >> >>13120: 1 already in queue awaiting acceptance (454 occurrences) >> >> >> >>I've recently ran into a situation at $work where I could not catch >> >>the culprit application via "netstat -A" and had to dive into kgdb to >> >>find the port from pcb where this application was listening to. >> >> >> >>IMO, this change will make debugging easier. >> >> >> >>cheers, >> >>Hiren >> >> >> >>Index: sys/kern/uipc_socket.c >> >>=================================================================== >> >>--- sys/kern/uipc_socket.c (revision 262861) >> >>+++ sys/kern/uipc_socket.c (working copy) >> >>@@ -136,6 +136,7 @@ >> >>#include >> >>#include >> >>#include >> >>+#include >> >> >> >>#include >> >> >> >>@@ -491,8 +492,11 @@ >> >> static int overcount; >> >> >> >> struct socket *so; >> >>+ struct inpcb *inp; >> >> int over; >> >> >> >>+ inp = sotoinpcb(head); >> >>+ >> >> ACCEPT_LOCK(); >> >> over = (head->so_qlen > 3 * head->so_qlimit / 2); >> >> ACCEPT_UNLOCK(); >> >>@@ -504,10 +508,12 @@ >> >> overcount++; >> >> >> >> if (ratecheck(&lastover, &overinterval)) { >> >>- log(LOG_DEBUG, "%s: pcb %p: Listen queue overflow: " >> >>- "%i already in queue awaiting acceptance " >> >>+ log(LOG_DEBUG, "%s: pcb %p: Listen queue overflow on " >> >>+ "port %d: %i already in queue awaiting acceptance " >> >> "(%d occurrences)\n", >> >>- __func__, head->so_pcb, head->so_qlen, overcount); >> >>+ __func__, head->so_pcb, >> >>+ ntohs(inp->inp_inc.inc_lport), head->so_qlen, >> >>+ overcount); >> >> >> >> overcount = 0; >> >> } >> >>_______________________________________________ >> >>freebsd-net@freebsd.org mailing list >> >>http://lists.freebsd.org/mailman/listinfo/freebsd-net >> >>To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> >_______________________________________________ >> >freebsd-net@freebsd.org mailing list >> >http://lists.freebsd.org/mailman/listinfo/freebsd-net >> >To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > >> >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"