From owner-svn-src-all@freebsd.org Sun Jan 5 14:37:46 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B26F01F6201; Sun, 5 Jan 2020 14:37:46 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47rLpK4pklz4MNv; Sun, 5 Jan 2020 14:37:45 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm1-x341.google.com with SMTP id d73so12473068wmd.1; Sun, 05 Jan 2020 06:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=/zJ9J222Np/+QIvOhu0JCmCPXMScas+RhXF300UXiuM=; b=LnV/C7+6WDJM/9/Ay7jWxrioy2oz2X7RG7XDKDOvVHZLxezj/DE2OtlZYhWlrQvXG6 Q58sf2KNs6gkHlHX4BhaOT1fWki5u2blFsgR/H8BR77RNvhzVW2uBmwQRJ2BY5KdIFuQ I78w75WEmL0LSqRe6PcC/m/aTGCMP9xDtcyygZ0Al7RaLlqG6X9HRziIDSDM9a2Q6fPk d1WdQIRpc9/xN44JoWPN62zvTjx3SVErLBtQEV0M0GiiUVSPsPXbdrl1Ip8jXtzRnL1c IgMlppEQdARCtsno3soDxUDzs8yxPmhsv+9zwCN/lMOzab4tk3IBJUo8Lru89bonxQM0 6kjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=/zJ9J222Np/+QIvOhu0JCmCPXMScas+RhXF300UXiuM=; b=CpXlDoIaeSWywQnrmjs7ktYk05WluFP2R7OiBTYlLDw0IYBMlpgfmenzLKrrrl4GDT IRk51m7nmsKXtuL4vgyCh9IIWkovdkj1ZB1NZdSa0xIt+oDozp1x3HboNpsWt9eCZfu2 XqqxcZVloCmrFYG2DWRL2ZJ4uYrf9MC8MQKUxnlgi92H9xdw5mjiDMfdVmc6/QdS5Tzu ZsC71i+ZfegxhbWusvo0pwZgkZNg0spe8cOl3AtGjRXqYRqxprNDlf8EHTcojfDkzZ7p pho5KK8SCYUUf0Lk3YRP0SnpFxoC7DLyhvWCwAMrAiGzUMQan4WpTKnAlnJxBhOd7ajd LwZA== X-Gm-Message-State: APjAAAXtXLLYP0NaT38V/xtSRIVQRBWzmxcDGgZXxWaNNhrmZ8+CJkeL WwmDL6R+uMMYqSLBx+avv9OJP2wt X-Google-Smtp-Source: APXvYqyF3G0T8BgQ3om/lC6a159f5xKnS2cfsbc4cv8EdG0k0yw2y+1lIbDs6kn/iAukUBx2W0EPtw== X-Received: by 2002:a7b:cbcd:: with SMTP id n13mr29570710wmi.104.1578235063716; Sun, 05 Jan 2020 06:37:43 -0800 (PST) Received: from brick (cpc92302-cmbg19-2-0-cust461.5-4.cable.virginm.net. [82.1.209.206]) by smtp.gmail.com with ESMTPSA id j12sm72943679wrw.54.2020.01.05.06.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2020 06:37:42 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 5 Jan 2020 14:37:43 +0000 From: Edward Tomasz Napierala To: Dmitry Chagin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356241 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/linux i386/linux Message-ID: <20200105143743.GA22122@brick> Mail-Followup-To: Dmitry Chagin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201912312201.xBVM1889057554@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 47rLpK4pklz4MNv X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=LnV/C7+6; dmarc=none; spf=pass (mx1.freebsd.org: domain of etnapierala@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=etnapierala@gmail.com X-Spamd-Result: default: False [-2.07 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-0.997,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.37)[ip: (2.65), ipnet: 2a00:1450::/32(-2.61), asn: 15169(-1.86), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FORGED_SENDER(0.30)[trasz@freebsd.org,etnapierala@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[206.209.1.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[trasz@freebsd.org,etnapierala@gmail.com] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jan 2020 14:37:46 -0000 HNY, and sorry for the late response. Now... I don't know. Looking at sys/amd64/linux/linux_locore.asm, it looks like __vdso_getcpu() should return ENOSYS, but for some reason the getcpu(2) syscall works just fine. The VDSO symbol doesn't get used for some reason? On 0101T0116, Dmitry Chagin wrote: > Hi, HNY! What about vdso? > > ср, 1 янв. 2020 г. в 01:01, Edward Tomasz Napierala : > > > Author: trasz > > Date: Tue Dec 31 22:01:08 2019 > > New Revision: 356241 > > URL: https://svnweb.freebsd.org/changeset/base/356241 > > > > Log: > > Add basic getcpu(2) support to linuxulator. The purpose of this > > syscall is to query the CPU number and the NUMA domain the calling > > thread is currently running on. The third argument is ignored. > > It doesn't do anything regarding scheduling - it's literally > > just a way to query the current state, without any guarantees > > you won't get rescheduled an opcode later. > > > > This unbreaks Java from CentOS 8 > > (java-11-openjdk-11.0.5.10-0.el8_0.x86_64). > > > > Reviewed by: kib > > MFC after: 2 weeks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D22972 > > > > Modified: > > head/sys/amd64/linux/linux_dummy.c > > head/sys/amd64/linux32/linux32_dummy.c > > head/sys/arm64/linux/linux_dummy.c > > head/sys/compat/linux/linux_misc.c > > head/sys/i386/linux/linux_dummy.c > > > > Modified: head/sys/amd64/linux/linux_dummy.c > > > > ============================================================================== > > --- head/sys/amd64/linux/linux_dummy.c Tue Dec 31 18:58:29 2019 > > (r356240) > > +++ head/sys/amd64/linux/linux_dummy.c Tue Dec 31 22:01:08 2019 > > (r356241) > > @@ -102,8 +102,6 @@ DUMMY(tee); > > DUMMY(vmsplice); > > /* Linux 2.6.18: */ > > DUMMY(move_pages); > > -/* Linux 2.6.19: */ > > -DUMMY(getcpu); > > /* Linux 2.6.22: */ > > DUMMY(signalfd); > > /* Linux 2.6.27: */ > > > > Modified: head/sys/amd64/linux32/linux32_dummy.c > > > > ============================================================================== > > --- head/sys/amd64/linux32/linux32_dummy.c Tue Dec 31 18:58:29 2019 > > (r356240) > > +++ head/sys/amd64/linux32/linux32_dummy.c Tue Dec 31 22:01:08 2019 > > (r356241) > > @@ -108,8 +108,6 @@ DUMMY(tee); > > DUMMY(vmsplice); > > /* Linux 2.6.18: */ > > DUMMY(move_pages); > > -/* Linux 2.6.19: */ > > -DUMMY(getcpu); > > /* Linux 2.6.22: */ > > DUMMY(signalfd); > > /* Linux 2.6.27: */ > > > > Modified: head/sys/arm64/linux/linux_dummy.c > > > > ============================================================================== > > --- head/sys/arm64/linux/linux_dummy.c Tue Dec 31 18:58:29 2019 > > (r356240) > > +++ head/sys/arm64/linux/linux_dummy.c Tue Dec 31 22:01:08 2019 > > (r356241) > > @@ -104,8 +104,6 @@ DUMMY(tee); > > DUMMY(vmsplice); > > /* Linux 2.6.18: */ > > DUMMY(move_pages); > > -/* Linux 2.6.19: */ > > -DUMMY(getcpu); > > /* Linux 2.6.27: */ > > DUMMY(signalfd4); > > DUMMY(inotify_init1); > > > > Modified: head/sys/compat/linux/linux_misc.c > > > > ============================================================================== > > --- head/sys/compat/linux/linux_misc.c Tue Dec 31 18:58:29 2019 > > (r356240) > > +++ head/sys/compat/linux/linux_misc.c Tue Dec 31 22:01:08 2019 > > (r356241) > > @@ -2353,3 +2353,19 @@ out: > > td->td_retval[0] = dst - args->buf; > > return (error); > > } > > + > > +int > > +linux_getcpu(struct thread *td, struct linux_getcpu_args *args) > > +{ > > + int cpu, error, node; > > + > > + cpu = td->td_oncpu; /* Make sure it doesn't change during > > copyout(9) */ > > + error = 0; > > + node = 0; /* XXX: Fake NUMA node 0 for now */ > > + > > + if (args->cpu != NULL) > > + error = copyout(&cpu, args->cpu, sizeof(l_int)); > > + if (args->node != NULL) > > + error = copyout(&node, args->node, sizeof(l_int)); > > + return (error); > > +} > > > > Modified: head/sys/i386/linux/linux_dummy.c > > > > ============================================================================== > > --- head/sys/i386/linux/linux_dummy.c Tue Dec 31 18:58:29 2019 > > (r356240) > > +++ head/sys/i386/linux/linux_dummy.c Tue Dec 31 22:01:08 2019 > > (r356241) > > @@ -104,8 +104,6 @@ DUMMY(tee); > > DUMMY(vmsplice); > > /* Linux 2.6.18: */ > > DUMMY(move_pages); > > -/* Linux 2.6.19: */ > > -DUMMY(getcpu); > > /* Linux 2.6.22: */ > > DUMMY(signalfd); > > /* Linux 2.6.27: */ > >