Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Aug 2017 16:13:41 +0200
From:      Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        Baptiste Daroussin <bapt@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org
Subject:   Re: svn commit: r448610 - in head/devel/leatherman: . files
Message-ID:  <20170823141341.GC13824@blogreen.org>
In-Reply-To: <07e78928-8cc8-a9ca-4273-abcf5f68e9d5@FreeBSD.org>
References:  <201708231317.v7NDHEGS099253@repo.freebsd.org> <20170823132505.s7kakyqgyb5tdy42@ivaldir.net> <20170823134551.GA13824@blogreen.org> <07e78928-8cc8-a9ca-4273-abcf5f68e9d5@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ncSAzJYg3Aa9+CRW
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 23, 2017 at 03:51:25PM +0200, Mathieu Arnold wrote:
> Patches are immutable files, there must not be any keyword expansion in
> them.

Thank you for the explanation.

As far as I can see, I can fix this by simply removing the first 3 lines
of each patch.  Can you confirm this?

There seems to not be svn:keywords property BTW, so I guess nothing more
is required:

% LC_ALL=3DC svn proplist patch-cmake_cflags.cmake
Properties on 'patch-cmake_cflags.cmake':
  fbsd:nokeywords
  svn:eol-style
  svn:mime-type

> I spent quite some time cleaning up the ports tree, and I thought
> I had added a pre-commit hook forbidding patch files with svn:keyword set.

Most of my ports may have some similar $FreeBSD$ keywords, I'll fix this
as well.

--=20
Romain Tarti=E8re <romain@FreeBSD.org>  http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated)

--ncSAzJYg3Aa9+CRW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAlmdjZUACgkQuk0dlVES
M2891QwAgDQ3LzXvtNujHaD/0yK+VhEDFunJyuhto7PTaWd4PRI+c54LrjzpOaIi
Pm3+3MS++3R52hrr3qrS3/gXZW7gPzLcQH4fwjMgXQ0eOs+8kqHZu15uVKz5lHrU
K5Asoj4Hqep1IE2XevcqRqy1k/ToXsxNX9tBpI2z+YvU9i1jwDolbiWzvQZ9BsCC
m7X1CHVgrn4Y9mXGhgXCx6Wxz9vspEvhnKIf79HhFgPrExAkTOY1VMB97J8hA91h
LmKhhsewSdzW4LuZvOhT0TLApFatfLkSgChup8c3mWHdpX/Ci14NMgOf0fM0eHy7
BTp/ofzPssiWT8NR0TvHcHOiM7WlPvdzCLCIGlAVqUXm89LyBLwlw/sisPVXb/GP
mzse6nCKKaenQ6LZTyR42W7vGLkFED7wQlhFCYDSLHVfEFIPkff9X6IuFUNxUTRB
5if1wv94MQk3n6gGLMb9m/MrQmbLi2mX1Bq+onsIFRe942jQN2hi0BfatMP/LrCO
f8DdcrHW
=mYNv
-----END PGP SIGNATURE-----

--ncSAzJYg3Aa9+CRW--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170823141341.GC13824>