Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Mar 2016 17:06:36 +0000 (UTC)
From:      Roman Bogorodskiy <novel@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r411194 - head/deskutils/spice-gtk
Message-ID:  <201603151706.u2FH6agr005785@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: novel
Date: Tue Mar 15 17:06:36 2016
New Revision: 411194
URL: https://svnweb.freebsd.org/changeset/ports/411194

Log:
  deskutils/spice-gtk: fix BUILD_DEPENDS when GSTREAMER is off
  
  The deskutils/spice-gtk port adds 'python' to USES only when
  SPICE_SLAVE is defined. However, it unconditionally adds python
  dependencies to BUILD_DEPENDS and uses PYTHON_PKGNAMEPREFIX
  that's defined via USES=python, and that looks like a bug.
  
  However, when GSTREAMER option is enabled (that's the default),
  Mk/bsd.gstreamer.mk sets PYTHON_PKGNAMEPREFIX to 'py*-' if it's
  not defined, so the bug is not triggered with the default options
  set, but fails when GSTREAMER is disabled.
  
  Fix this by unconditionally adding 'python' to USES.
  
  Approved by:	Oleg Ginzburg (maintainer, via email)

Modified:
  head/deskutils/spice-gtk/Makefile

Modified: head/deskutils/spice-gtk/Makefile
==============================================================================
--- head/deskutils/spice-gtk/Makefile	Tue Mar 15 17:01:33 2016	(r411193)
+++ head/deskutils/spice-gtk/Makefile	Tue Mar 15 17:06:36 2016	(r411194)
@@ -13,7 +13,7 @@ LICENSE=	GPLv2
 
 USE_XORG=	pixman
 USE_GNOME=	gnomeprefix gtk20 gtk30 intltool introspection:build
-USES=		cpe gmake jpeg libtool pkgconfig tar:bzip2 pathfix
+USES=		cpe gmake jpeg libtool pkgconfig tar:bzip2 pathfix python
 CPE_VENDOR=	redhat
 
 BUILD_DEPENDS=	spice-protocol>=0.12.10:${PORTSDIR}/devel/spice-protocol \
@@ -27,7 +27,6 @@ BUILD_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}g
 RUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}gtk2>=0:${PORTSDIR}/x11-toolkits/py-gtk2
 CONFIGURE_ARGS+=	--with-python
 PLIST_FILES+=	%%PYTHON_SITELIBDIR%%/SpiceClientGtk.so
-USES+=	python
 .endif
 
 CONFIGURE_ENV+=	SSL_CFLAGS=-I${OPENSSLINC} \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603151706.u2FH6agr005785>