Date: Wed, 11 Jun 2003 23:56:22 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c pccbbvar.h Message-ID: <20030611.235622.75446360.imp@bsdimp.com> In-Reply-To: <20030611225111.E42109@root.org> References: <20030612033735.0B7D337B495@hub.freebsd.org> <20030611225111.E42109@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20030611225111.E42109@root.org> Nate Lawson <nate@root.org> writes: : On Wed, 11 Jun 2003, Warner Losh wrote: : > Modified files: : > sys/dev/pccbb pccbb.c pccbbvar.h : > Log: : > Make cbb interrupts MPSAFE: : : We need to have you at bsdcon 24/7. ;-) : : > --- src/sys/dev/pccbb/pccbb.c:1.75 Sat Jun 7 13:47:35 2003 : > +++ src/sys/dev/pccbb/pccbb.c Wed Jun 11 20:37:28 2003 : > @@ -1080,7 +1087,11 @@ : > } : > if (sc->flags & CBB_CARD_OK) { : > STAILQ_FOREACH(ih, &sc->intr_handlers, entries) { : > + if ((ih->flags & INTR_MPSAFE) != 0) : > + mtx_lock(&Giant); : > (*ih->intr)(ih->arg); : > + if ((ih->flags & INTR_MPSAFE) != 0) : > + mtx_lock(&Giant); : > } : > } : > } : : Isn't that second call supposed to be an unlock? Yes. I don't know how my system is working at all with that :-(
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030611.235622.75446360.imp>