From owner-svn-ports-head@freebsd.org Fri Jul 22 13:17:57 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38C5DB9FC64 for ; Fri, 22 Jul 2016 13:17:57 +0000 (UTC) (envelope-from kris@ixsystems.com) Received: from barracuda.ixsystems.com (barracuda.ixsystems.com [12.229.62.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.ixsystems.com", Issuer "Go Daddy Secure Certificate Authority - G2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A4C71F39 for ; Fri, 22 Jul 2016 13:17:57 +0000 (UTC) (envelope-from kris@ixsystems.com) X-ASG-Debug-ID: 1469193476-08ca0410fd17a160001-7kGxFj Received: from zimbra.ixsystems.com ([10.246.0.20]) by barracuda.ixsystems.com with ESMTP id yMMSXeuQWyk24I6j (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 22 Jul 2016 06:17:56 -0700 (PDT) X-Barracuda-Envelope-From: kris@ixsystems.com X-Barracuda-RBL-Trusted-Forwarder: 10.246.0.20 X-ASG-Whitelist: Client Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id 2FFD0E03E1E; Fri, 22 Jul 2016 06:17:56 -0700 (PDT) Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 50G2WFoPk7So; Fri, 22 Jul 2016 06:17:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id A0EB3E03DED; Fri, 22 Jul 2016 06:17:55 -0700 (PDT) X-Virus-Scanned: amavisd-new at ixsystems.com Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CH89HAF1vm6S; Fri, 22 Jul 2016 06:17:55 -0700 (PDT) Received: from [172.20.0.10] (vpn.ixsystems.com [10.249.0.2]) by zimbra.ixsystems.com (Postfix) with ESMTPSA id B1B16E03D4B; Fri, 22 Jul 2016 06:17:54 -0700 (PDT) Subject: Re: [SPAM] Re: svn commit: r418889 - in head/deskutils: . copyq To: Adam Weinberger , Alexey Dokuchaev X-ASG-Orig-Subj: Re: [SPAM] Re: svn commit: r418889 - in head/deskutils: . copyq References: <201607211847.u6LIluTh087613@repo.freebsd.org> <20160722044657.GC37437@FreeBSD.org> <91496634-0037-4256-951C-F8A8ABF284A9@adamw.org> Cc: Kris Moore , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Kris Moore Message-ID: Date: Fri, 22 Jul 2016 09:17:53 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <91496634-0037-4256-951C-F8A8ABF284A9@adamw.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: UNKNOWN[10.246.0.20] X-Barracuda-Start-Time: 1469193476 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://10.246.0.26:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ixsystems.com X-Barracuda-BRTS-Status: 1 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 13:17:57 -0000 On 07/22/2016 00:56, Adam Weinberger wrote: >> On 21 Jul, 2016, at 22:46, Alexey Dokuchaev wrote: >> >> On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote: >>> New Revision: 418889 >>> URL: https://svnweb.freebsd.org/changeset/ports/418889 >>> >>> Log: >>> CopyQ is advanced clipboard manager with editing and scripting features. >>> >>> WWW: https://github.com/hluk/CopyQ >>> >>> [...] >>> +USE_XORG+= x11 xfixes xtst >> What's the reason for += here? >> >>> +USE_QT5= core gui network svg multimedia imageformats \ >> Spaces were used in this line instead of proper tab. >> >>> +USE_GL+= gl >> Bogus += again. >> >>> +USES= qmake >> Spaces again; also it's better to place more generic USES *before* specific >> USE_FOO knobs. >> >>> +PLIST_FILES= bin/copyq >> PLIST-related knobs should be among the last ones (after USE* knobs, but >> before OPTIONS* knobs). > AFAIK we've never specified ordering after _DEPENDS. FWIW, Kris's ordering makes sense to me; the variables are ordered by decreasing probability of future modification. Though I do agree about all the +='s. > > # Adam > > Fixed those, thanks guys! -- Kris Moore iXsystems Enterprise Storage & Servers Driven By Open Source