From owner-svn-src-all@freebsd.org Wed Apr 5 05:24:31 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85B8DD2FA51; Wed, 5 Apr 2017 05:24:31 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 39D2DDB9; Wed, 5 Apr 2017 05:24:31 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id vdQicwjVDsa1kvdQjc39fQ; Tue, 04 Apr 2017 23:24:29 -0600 X-Authority-Analysis: v=2.2 cv=W+NIbVek c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=AzvcPWV-tVgA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=8E7CtRF3Sqf9juMs07AA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id D2B3D180; Tue, 4 Apr 2017 22:24:27 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v355OQjs083798; Tue, 4 Apr 2017 22:24:26 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201704050524.v355OQjs083798@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316516 - head/etc In-Reply-To: Message from Cy Schubert of "Wed, 05 Apr 2017 05:23:09 -0000." <201704050523.v355N9km082808@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 04 Apr 2017 22:24:26 -0700 X-CMAE-Envelope: MS4wfG00vTbYu8kWTEnEYYrQz8+0NHCZO17puPfmqGpLhYiTgwnpLFFWo7XyNM9dLzLAh+iUPmZD9UwM7DnQusHX8Mpx0aojMrtlJ89npX2/paTHmx2VToBe J4XjJ2kr2oBGcDQLX8ToYZAmiEaKAmLeV90V8WjoULrgfPIqPtjXvPg4XOOgQyrG2Rzx0XWZslfjWDq1AhoEylSmS/palI0tWOL6a02sDQZORS4CgVbTq39x sq+6JC8lxEX3kPaP+dx5Q7fJzSm+877cKcVn9Wup3KA1rHqhrIC+ByOsWoeC8iPt X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 05:24:31 -0000 In message <201704050523.v355N9km082808@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Wed Apr 5 05:23:09 2017 > New Revision: 316516 > URL: https://svnweb.freebsd.org/changeset/base/316516 > > Log: > r316487 altered the defined values of rc_force from "yes" (for yes) > and NULL (for no) to "no" (for no) and no change to the definition > of yes. Two rc.d scripts, dhclient and bgfsck check rc_force for > yesi, using test -n, and no, using test -z. The redefinition of > yes and no by r316487 caused rc.d/dhclient, when invoked by devd > using a devd.conf rule, to assign DHCP assigned IP addresses for > interfaces with statically assigned interfaces, breaking boot. > Point of breakage was at line 25 of etc/rc.d/dhclient (r301068) > where $rc_force needs to be NULL. > > MFC after: 3 weeks > X-MFC with: r316487 discussed with: ngie > > Modified: > head/etc/rc.subr > > Modified: head/etc/rc.subr > ============================================================================= > = > --- head/etc/rc.subr Wed Apr 5 05:01:23 2017 (r316515) > +++ head/etc/rc.subr Wed Apr 5 05:23:09 2017 (r316516) > @@ -929,6 +929,9 @@ run_rc_command() > eval ${rcvar}=YES > fi > fi > + if ! checkyesno rc_force; then > + rc_force= > + fi > debug "_rc_prefix=${_rc_prefix}" > > eval _override_command=\$${name}_program > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.