From owner-freebsd-hackers@FreeBSD.ORG Wed Apr 19 07:26:30 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB4CC16A48C; Wed, 19 Apr 2006 07:26:30 +0000 (UTC) (envelope-from marco@goofy.tols.org) Received: from goofy.tols.org (goofy.demon.nl [83.160.134.92]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB96A43D69; Wed, 19 Apr 2006 07:26:29 +0000 (GMT) (envelope-from marco@goofy.tols.org) Received: from goofy.tols.org (localhost [127.0.0.1]) by goofy.tols.org (8.13.4/8.13.4) with ESMTP id k3J7QRAu066065; Wed, 19 Apr 2006 07:26:27 GMT (envelope-from marco@goofy.tols.org) Received: (from marco@localhost) by goofy.tols.org (8.13.4/8.13.4/Submit) id k3J7QRD0066064; Wed, 19 Apr 2006 07:26:27 GMT (envelope-from marco) Date: Wed, 19 Apr 2006 07:26:27 +0000 From: Marco van Tol To: John Baldwin Message-ID: <20060419072627.GA66012@tols.org> Mail-Followup-To: John Baldwin , freebsd-hackers@freebsd.org References: <20060412215021.GB1146@tols.org> <20060417134825.GA47043@tols.org> <20060418221505.GC58081@tols.org> <200604181838.27713.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604181838.27713.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV 0.88.1/1407/Tue Apr 18 21:01:55 2006 on goofy.tols.org X-Virus-Status: Clean X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on goofy.tols.org Cc: freebsd-hackers@freebsd.org Subject: Re: Per CPU cpu-statistics under SMP X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 07:26:31 -0000 On Tue, Apr 18, 2006 at 06:38:26PM -0400, John Baldwin wrote: > On Tuesday 18 April 2006 18:15, Marco van Tol wrote: [...] > > I'm trying to apply the patch. Tried it to both todays current and todays > > RELENG_6, but both have failing hunks in sys/kern/kern_clock.c. > > The rest succeeds. > > > > I can do two things: > > - Try to manually patch it against todays current. > > - re-checkout todays RELENG_6, and download the relevant files from the > > cvsweb interface from the date you posted the patch from that days > > CURRENT. Then try to apply the patch. > > > > For the latter it may break the kernelbuild, but I'm very tempted to try > > that one ahead of the manual patching attempt. ;) > > > > I'll keep you posted on how far I'm getting with this. Guess I should have > > gone straight to current the day you posted the patch. Sorry. > > Ah, hmm. On 6.x we don't have per-thread stat ticks yet, which is > probably why it is failing. It also isn't safe to move sched_lock > down either on 6.x. You can still apply the rest of the patch by > hand, just leave the 'mtx_lock_spin(&sched_lock)' where it is and > change all the 'cp_time[FOO]++' to 'PCPU_LAZY_INC(cp_time[FOO])'. OK, thanks. What I will do is replace my gentoo partition with a BSD current partition so I don't loose my workstation as it were, and use that to work on this. Will let you know how that goes. Thanks. Marco -- Als de redding het hoogst is, is de nood nabij!