From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 1 13:30:19 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DD9616A4B3 for ; Sun, 1 Oct 2006 13:30:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6122443D66 for ; Sun, 1 Oct 2006 13:30:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k91DUDUw081262 for ; Sun, 1 Oct 2006 13:30:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k91DUDLB081256; Sun, 1 Oct 2006 13:30:13 GMT (envelope-from gnats) Resent-Date: Sun, 1 Oct 2006 13:30:13 GMT Resent-Message-Id: <200610011330.k91DUDLB081256@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Richard J. Dawes" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D5B716A416 for ; Sun, 1 Oct 2006 13:24:13 +0000 (UTC) (envelope-from eps@epstais.com) Received: from epstais.com (epstais.com [69.55.224.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 572BE43D9C for ; Sun, 1 Oct 2006 13:24:02 +0000 (GMT) (envelope-from eps@epstais.com) Received: from epstais.com (epstais.com [69.55.224.118]) by epstais.com (8.12.9p2/8.12.9) with ESMTP id k91DO12e012239; Sun, 1 Oct 2006 06:24:01 -0700 (PDT) (envelope-from eps@epstais.com) Received: (from root@localhost) by epstais.com (8.12.9p2/8.12.9/Submit) id k91DO1w0012124; Sun, 1 Oct 2006 06:24:01 -0700 (PDT) (envelope-from eps) Message-Id: <200610011324.k91DO1w0012124@epstais.com> Date: Sun, 1 Oct 2006 06:24:01 -0700 (PDT) From: "Richard J. Dawes" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: "Richard J. Dawes" Subject: ports/103868: [PATCH] audio/xmms2 Makefile (v1.18) breaks "make index" X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2006 13:30:19 -0000 >Number: 103868 >Category: ports >Synopsis: [PATCH] audio/xmms2 Makefile (v1.18) breaks "make index" >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sun Oct 01 13:30:12 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Richard J. Dawes >Release: FreeBSD 4.9-RELEASE-p13-jc2 i386 >Organization: >Environment: System: FreeBSD epstais.com 4.9-RELEASE-p13-jc2 FreeBSD 4.9-RELEASE-p13-jc2 #9: Tue Jun 7 00:30:36 PDT 2005 user@jail16.johncompanies.com:/usr/obj/usr/src/sys/jail16 i386 4.9-RELEASE cvsup of ports-all as of Sept. 30 evening (PDT) >Description: The final entry in the OPTIONS line -- intended to be commented out -- ends with the '\' line-extender character. The effect is that the following .endif is taken as part of OPTIONS and not as the .if closer, by "make index" or other indexing utilities (e.g. "portsdb -U"). I say this is "serious" as it breaks the port upgrade workflow for everyone, not just audio/xmms2 users. I suspect there may be problems building the port, but I don't use it myself. The "make index" error reported follows. Note that this Makefile is seen first via audio/cpp-xmms2/Makefile, where it is .include'd ... "/usr/ports/audio/cpp-xmms2/../xmms2/Makefile", line 221: Unclosed conditional/for loop "Makefile", line 35: 1 open conditional make: fatal errors encountered -- cannot continue ===> audio/cpp-xmms2 failed *** Error code 1 1 error >How-To-Repeat: Run "make index" from the Ports Collection base directory, with ports-audio cvsup'ed as recently as Wed Sep 27 15:07:33 2006 UTC (timestamp on commit to Makefile v1.18 in CVS). >Fix: Remove the offending '\' character, by editing the Makefile v1.18 or by applying the following diff with the 'patch' utility. --- Makefile.diff-against-1.18 begins here --- --- Makefile Sat Sep 30 18:28:09 2006 +++ Makefile.fixed Sun Oct 1 05:44:36 2006 @@ -52,7 +52,7 @@ MDNS_AVAHI "Support to announce XMMS2d via mDNS (Avahi)" off \ MDNS_APPLE "Support to announce XMMS2d via mDNS (Apple)" on \ JACK "Support to output via the Jack output server" off #\ -# SDL "Support for visualization" on \ +# SDL "Support for visualization" on .endif .include --- Makefile.diff-against-1.18 ends here --- >Release-Note: >Audit-Trail: >Unformatted: