From owner-svn-src-head@freebsd.org  Mon May 13 16:44:18 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A97621594954;
 Mon, 13 May 2019 16:44:18 +0000 (UTC)
 (envelope-from delphij@gmail.com)
Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com
 [IPv6:2607:f8b0:4864:20::d34])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B4EEE89F6B;
 Mon, 13 May 2019 16:44:17 +0000 (UTC)
 (envelope-from delphij@gmail.com)
Received: by mail-io1-xd34.google.com with SMTP id x24so3147677ion.5;
 Mon, 13 May 2019 09:44:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=owzjXIt3bRBvMlIikYEvwpek1MzaeHp0d6J9Cpt9Utw=;
 b=OK4xai17M74G2dDJvcDGB9yfPef/UMnGAo7RmzneZPjPewXe1h+cSEnLikaBHBjQ22
 sNf0+k1JtLWLNbDV/HxXOOH1jK6XMJwlF3BJnjDg99QWq/bga7ZDdwj78OHFB7JH6X5g
 2vaqXTjE9CfJQlBtmvGboYi7A5vLRHoogQWLjiOvNlVXztePGOegeybO0JLjiQpVGh8y
 geffmjszQRkfRzhO5gbvrS1WXhf8dk6S5K95O2ayVA+LZT2Jx8ruxbD+N7dzYZ6nCwi8
 HwWewU5etJ2dnF5UVXrBHwWcHAA1dqn4AWXkP2Mg+f6UvBDd0x/5jljIcCpm597f2l4Z
 Lctg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=owzjXIt3bRBvMlIikYEvwpek1MzaeHp0d6J9Cpt9Utw=;
 b=ZOhjqAOhZJ1VM5U3h+R5vsW4/ZASVYeI9qJSgucZJoCouYqIxU50+VIghZFZ40nmG8
 ldxTUc4YvqBdWTmnDp2Rn0ueh17VWyqoptaBhQMRqOGOWHeWaUyzZGrv0xJTeKDc05LQ
 L97lVtrgCyLTDo7uU09yEWlIwJXpMjvL436K/s9CjHmyO9pQ7Db5YDL1nPs22Pf7p84n
 mVsAga0WUKyGIaY6NTfsqvYJ7yB9XUWpmB6qUAlXWHLgZq5uQr9MCCq5XH3r3A3ic7I7
 Xwl6/OLb7Ugoib2DlGYLdH1W8/w/6WSxNSvAjFbl5gP1m3XO+XlLX+w84kYvRc/vALKB
 gHxg==
X-Gm-Message-State: APjAAAXuklQ3slSLcqD6T5ezNQcWNFPEB6Kr6Ik7bm4tL4uWUTdqglpa
 qslxrlUCh3EgqO7LAllKCs6DSBLAP3Mw5mndpC+5aVtw
X-Google-Smtp-Source: APXvYqw2K+wR4zyrDug2JeRjlT26oGvp/M1a5v5ocdeVq0npcf2nOFuGCyUDPV3RCH/daQt09VZZ2Pnsl48KjePSA9E=
X-Received: by 2002:a6b:8f51:: with SMTP id r78mr17414682iod.110.1557765856765; 
 Mon, 13 May 2019 09:44:16 -0700 (PDT)
MIME-Version: 1.0
References: <freebsd@gndrsh.dnsmgr.net>
 <201905111637.x4BGbAWj032623@gndrsh.dnsmgr.net>
 <201905111741.x4BHflXP008848@slippy.cwsent.com>
In-Reply-To: <201905111741.x4BHflXP008848@slippy.cwsent.com>
From: Xin LI <delphij@gmail.com>
Date: Mon, 13 May 2019 09:44:05 -0700
Message-ID: <CAGMYy3u3kk2PeYqkJEuom1yi0xWa71BxDu4k6tcQD_BA-bSW0A@mail.gmail.com>
Subject: Re: svn commit: r347488 - head/usr.sbin/ntp/ntpd
To: Cy Schubert <Cy.Schubert@cschubert.com>
Cc: rgrimes@freebsd.org, Ian Lepore <ian@freebsd.org>,
 Xin LI <delphij@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
X-Rspamd-Queue-Id: B4EEE89F6B
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org;
 dkim=pass header.d=gmail.com header.s=20161025 header.b=OK4xai17;
 dmarc=pass (policy=none) header.from=gmail.com;
 spf=pass (mx1.freebsd.org: domain of delphij@gmail.com designates
 2607:f8b0:4864:20::d34 as permitted sender) smtp.mailfrom=delphij@gmail.com
X-Spamd-Result: default: False [-6.52 / 15.00]; ARC_NA(0.00)[];
 TO_DN_EQ_ADDR_SOME(0.00)[];
 R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[];
 TO_DN_SOME(0.00)[];
 R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36];
 FREEMAIL_FROM(0.00)[gmail.com];
 MIME_GOOD(-0.10)[multipart/alternative,text/plain];
 RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0];
 TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+];
 DMARC_POLICY_ALLOW(-0.50)[gmail.com,none];
 RCPT_COUNT_SEVEN(0.00)[7];
 MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com];
 RCVD_IN_DNSWL_NONE(0.00)[4.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org
 : 127.0.5.0]; NEURAL_HAM_SHORT(-0.89)[-0.891,0];
 FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+];
 FREEMAIL_ENVFROM(0.00)[gmail.com];
 ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US];
 RCVD_COUNT_TWO(0.00)[2];
 IP_SCORE(-2.62)[ip: (-7.53), ipnet: 2607:f8b0::/32(-3.25), asn: 15169(-2.26),
 country: US(-0.06)]; 
 DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 May 2019 16:44:18 -0000

On Sat, May 11, 2019 at 10:42 AM Cy Schubert <Cy.Schubert@cschubert.com>
wrote:

> In message <201905111637.x4BGbAWj032623@gndrsh.dnsmgr.net>, "Rodney W.
> Grimes"
> writes:
> > > On Sat, 2019-05-11 at 14:22 +0000, Xin LI wrote:
> > > > Author: delphij
> > > > Date: Sat May 11 14:22:21 2019
> > > > New Revision: 347488
> > > > URL: https://svnweb.freebsd.org/changeset/base/347488
> > > >
> > > > Log:
> > > >   Update leap-seconds to leap-seconds.3757622400.
> > > >
> > >
> > > For future reference:  it's a bit better to get this file from NIST [*]
> > > than from USNO.  The USNO boilerplate is full of typos, and USNO
> > > incorrectly adjusts the "last update date" metadata every time they
> > > change the expiration date of the file.  That's not correct... as the
> > > boilerplate itself states, that field is only supposed to be updated
> > > when new leap seconds are added to the file.
> >
> > I would be very happy if that information would end up in the
> > top of, or next to the leap-seconds file so that it was followed
> > in the future, rather than being folk lore.
> >
> > Thanks,
> > Rod
>
> Leap seconds hasn't been updated upstream since 2017. USNO updates the
> file when they last paid attention to the file by not updating it. NIST
> only updates the file when there is indeed an update, that being Ian's
> point.
>

Yeah, obviously I somehow misread the commit message of r320256.  I can do
a follow commit to fix it tonight but if you have some time please feel
free to fix it now.

Cheers,