From owner-cvs-all@FreeBSD.ORG Wed Aug 25 22:15:42 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CED116A4D7; Wed, 25 Aug 2004 22:15:42 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39FD943D49; Wed, 25 Aug 2004 22:15:42 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 19FFA5C9B1; Wed, 25 Aug 2004 15:15:42 -0700 (PDT) Date: Wed, 25 Aug 2004 15:15:42 -0700 From: Alfred Perlstein To: Robert Watson Message-ID: <20040825221542.GB26612@elvis.mu.org> References: <200408252124.i7PLOaHa084709@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200408252124.i7PLOaHa084709@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 22:15:42 -0000 * Robert Watson [040825 14:24] wrote: > rwatson 2004-08-25 21:24:36 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_usrreq.c > Log: > Don't hold the UNIX domain socket subsystem lock over the body of the > UNIX domain socket garbage collection implementation, as that risks > holding the mutex over potentially sleeping operations (as well as > introducing some nasty lock order issues, etc). unp_gc() will hold > the lock long enough to do necessary deferal checks and set that it's > running, but then release it until it needs to reset the gc state. > > RELENG_5 candidate. > > Discussed with: alfred Which alfred? :) -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684