From owner-cvs-all@FreeBSD.ORG Wed Sep 14 17:40:57 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3366516A41F; Wed, 14 Sep 2005 17:40:57 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 695E443D45; Wed, 14 Sep 2005 17:40:56 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j8EHetFO019276; Wed, 14 Sep 2005 10:40:56 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20050914165300.GG59453@wombat.fafoe.narf.at> References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> <154E8DB1-C941-4477-9FB7-BD373DC11898@xcllnt.net> <20050914165300.GG59453@wombat.fafoe.narf.at> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Wed, 14 Sep 2005 10:40:54 -0700 To: Stefan Farfeleder X-Mailer: Apple Mail (2.734) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 17:40:57 -0000 On Sep 14, 2005, at 9:53 AM, Stefan Farfeleder wrote: >>> I waver between guarding the prototype with #ifndef __ASSEMBLER__ >>> and >>> moving it to another header, eg. . Opinions? >> >> I would go with #ifndef __ASSEMBLER__. I think the prototype is >> essentially in the right header. I did test your patch and it does >> the trick... > > That would require fixing xorg-server's usage of the header too. I > don't know how difficult this is. In that case, you might as well get the prototype out of there. I have no suggestion where to put it yet... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net