From nobody Sun Aug 17 17:30:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c4jXb3NmFz652V3; Sun, 17 Aug 2025 17:30:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c4jXZ3VJ8z44J0; Sun, 17 Aug 2025 17:30:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755451806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WK7wFuYWYSv7ghf9mncJ8FuRJCl7OIV8g70Zae3EKms=; b=nhUk8eVIs4UqU9UinuLS8f2BYqG/woGTDyIEBZbWcOM3sryDc1MgFbxciE0hg0X+8c/YAn +6K7xqkB2+uajLVfxwI9u1wqrLH12/pNF0KJ50aNoqxGsUmpuGrDAHkiAjaZ4av2bU6USa q+IWDmQgIDmLIHwkm9XAlh6hKguP2c7rzu+gt94rSW7Y5emJYAy3NqPNLWDSOH9aPxvEHC R2bpLPqsOMVvKsFbrmyaGURTgeWZRV0QCr6KkeRa525Hgd0skM4NSdYh4kvQbyn95BRDlt Vmor8qEhdWSoIVeysZW2dGCaRZ03cvQZGvRt8mQxkQjnFVzCOWG5P2CDH2vUzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755451806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WK7wFuYWYSv7ghf9mncJ8FuRJCl7OIV8g70Zae3EKms=; b=brMkAQR04Gk/VbVuUnl+EcPEphHg+bwKTqs1UJ4AzRsaxiNCvSasch+Eti7IAHLZcf1bBz +AEX+h8IvjB/QoGWBQ1deLMZeYQtUKyXO653eoZzru6XELFKnddd4IbiYcd9KY1x0RI7NY C4D1jl0G5SWkBrhltFdpt+o5Uzhus5A5ZaAIBuB5HZQO3YvB/BdL6g1dj1NozRMlWqDOi6 8nDT6n2n7Fh166Vvrk8CeI8PaVdfT29mfQZP4CAJ8GmrazIri5iYM8iuLaw80hLbjsZG0a dZMAZ60oQGai4r6yArRx2ewj3TMws/AWNCjpul9Weu3cxYGM7ErSLP8TImK/bA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755451806; a=rsa-sha256; cv=none; b=YdqNcmLI5EMrbpaqyWV7S5oexPRsVDZeLb90s62VLqTIkZvYGm3ZRYrmzUACV8cdnN7WGK 9sICoaP2iO5qH9ysFooQ6n5HRLQbTG2MuBcfMOFV0UskbbrKKObDae2pFdQUMkEM1ZftOB iqgC2N+5Aw/q1MyNuvwrmr5Wrq9klISt7PU4jycVx8DYOG1JXTVfpiUZXr9zP9Te4u7xI6 ycQBBk3OwDd3E7ab+Td9SU6OIXOuOZDzbHZqmvhJqDanhoTeQfeuTBY8z1GCkoBmQOEobN Etuos5Rr/0jGQVE9Qyv5tVLyxzagIQ2/mwQkqhTqRPAIYtfacGBpHUn6fDgUXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c4jXZ2twnz4Ls; Sun, 17 Aug 2025 17:30:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57HHU6Wq073784; Sun, 17 Aug 2025 17:30:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57HHU6Fp073779; Sun, 17 Aug 2025 17:30:06 GMT (envelope-from git) Date: Sun, 17 Aug 2025 17:30:06 GMT Message-Id: <202508171730.57HHU6Fp073779@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: f9ff1e48cc1b - main - vfs: Assert that st_rdev is NODEV for non-devices List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f9ff1e48cc1b77f1840fd514050ccc5904a0cac2 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=f9ff1e48cc1b77f1840fd514050ccc5904a0cac2 commit f9ff1e48cc1b77f1840fd514050ccc5904a0cac2 Author: Dag-Erling Smørgrav AuthorDate: 2025-08-17 17:08:56 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-08-17 17:29:28 +0000 vfs: Assert that st_rdev is NODEV for non-devices Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D51956 --- sys/kern/vfs_syscalls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index bf3ed9d515dc..aeb5657452dc 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -2571,6 +2571,8 @@ kern_statat(struct thread *td, int flag, int fd, const char *path, } error = VOP_STAT(nd.ni_vp, sbp, td->td_ucred, NOCRED); NDFREE_PNBUF(&nd); + KASSERT(error != 0 || VN_ISDEV(nd.ni_vp) || sbp->st_rdev == NODEV, + ("st_rdev should be NODEV unless the file is a device node")); vput(nd.ni_vp); #ifdef __STAT_TIME_T_EXT sbp->st_atim_ext = 0;