Date: Fri, 01 Jun 2018 16:22:07 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck Message-ID: <bug-227109-7788-eBB0m4SuDN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-227109-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-227109-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227109 --- Comment #16 from commit-hook@freebsd.org --- A commit references this bug: Author: mat Date: Fri Jun 1 16:20:51 UTC 2018 New revision: 471273 URL: https://svnweb.freebsd.org/changeset/ports/471273 Log: SC2155: Declare and assign separately to avoid masking return values. In the original code, the return value of mycmd is ignored, and export will instead always return true. This may prevent conditionals, set -e and traps from working correctly. PR: 227109 Submitted by: mat Sponsored by: Absolight Changes: head/Mk/Scripts/smart_makepatch.sh --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227109-7788-eBB0m4SuDN>