From owner-cvs-src@FreeBSD.ORG Mon Nov 14 14:17:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 257D816A41F; Mon, 14 Nov 2005 14:17:51 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3905843D46; Mon, 14 Nov 2005 14:17:49 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jAEEHm3v065635; Mon, 14 Nov 2005 16:17:48 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 63454-01; Mon, 14 Nov 2005 16:17:46 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jAEEECAC065546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Nov 2005 16:14:12 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id jAEEEKN9054447; Mon, 14 Nov 2005 16:14:20 +0200 (EET) (envelope-from ru) Date: Mon, 14 Nov 2005 16:14:20 +0200 From: Ruslan Ermilov To: Bill Paul Message-ID: <20051114141420.GW87446@ip.net.ua> References: <200511111604.jABG4xw3011845@repoman.freebsd.org> <20051113212345.330A316A420@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BcZrms9gUsdgyR6a" Content-Disposition: inline In-Reply-To: <20051113212345.330A316A420@hub.freebsd.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_arcsubr.c if_arp.h if_bridge.c if_ef.c if_ethersubr.c if_fddisubr.c if_fwsubr.c if_iso88 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2005 14:17:51 -0000 --BcZrms9gUsdgyR6a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bill, On Sun, Nov 13, 2005 at 09:23:45PM +0000, Bill Paul wrote: > [...] >=20 > > sys/compat/ndis subr_ndis.c=20 >=20 > [...] >=20 > > - Store pointer to the link-level address right in "struct ifnet" > > rather than in ifindex_table[]; all (except one) accesses are > > through ifp anyway. IF_LLADDR() works faster, and all (except > > one) ifaddr_byindex() users were converted to use ifp->if_addr. > > =20 > > - Stop storing a (pointer to) Ethernet address in "struct arpcom", > > and drop the IFP2ENADDR() macro; all users have been converted > > to use IF_LLADDR() instead. >=20 > For the umpity umpth time: I'm trying to keep it so that the same > NDIS code will compile on 7.x, 6.x and 5.x. Having one set of code > means I don't need to go nuts doing merges from one branch to the > next: I can just pull the files over and be done with it. >=20 Understood. > You did > not consider this when modifying subr_ndis.c, and now you have broken > it for the 6.x and 5.x branches. >=20 Yes I did. > More importantly, you broke it in > a very subtle way that only shows up as a kernel panic a runtime. >=20 Can you please give me more details about this panic? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --BcZrms9gUsdgyR6a Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDeJu7qRfpzJluFF4RAgcXAKCWHQA6jNIhDKlSaUC3X4Nm2esmlwCfd/mD 2c8Vmfr6RPJaICMKIb3ZSl4= =GeQQ -----END PGP SIGNATURE----- --BcZrms9gUsdgyR6a--