From owner-freebsd-bugs  Tue May 13 20:40:05 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id UAA11965
          for bugs-outgoing; Tue, 13 May 1997 20:40:05 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id UAA11927;
          Tue, 13 May 1997 20:40:02 -0700 (PDT)
Resent-Date: Tue, 13 May 1997 20:40:02 -0700 (PDT)
Resent-Message-Id: <199705140340.UAA11927@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, chi@rd.njk.co.jp
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id UAA11876;
          Tue, 13 May 1997 20:39:36 -0700 (PDT)
Message-Id: <199705140339.UAA11876@hub.freebsd.org>
Date: Tue, 13 May 1997 20:39:36 -0700 (PDT)
From: chi@rd.njk.co.jp
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: kern/3595: param counts not idential between definition and call(in netboot/ns8390.c)
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         3595
>Category:       kern
>Synopsis:       param counts not idential between definition and call(in netboot/ns8390.c)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 13 20:40:01 PDT 1997
>Last-Modified:
>Originator:     Chiharu Shibata
>Organization:
NJK Corporation
>Release:        FreeBSD-2.1.0R or later
>Environment:
FreeBSD carrot FreeBSD 2.1.0-RELEASE #0: Sat Jun  1 10:30:42  1996 h-nokubi@sassaby.nokubi.or.jp:/usr/src/sys/compile/GENERIC98
>Description:
(Sorry of my poor English.)
Functions eth_pio_read() and eth_pio_write() in netboot/ns8390.c are defined that 4 parameters required.
But these functios are called only 3 parameters.
Here is an abstract of ns8390.c
----
        eth_pio_write(test, 8192, sizeof(test));
        eth_pio_read(8192, testbuf, sizeof(test));
[snip]
eth_pio_read(src, dst, cnt, init)
        unsigned short src;
        unsigned char *dst;
        unsigned short cnt;
        int init;
{
----
>How-To-Repeat:
None.
>Fix:
I think "int init" which is 4th parameter is not necessary.
So cut it from definition of eth_pio_read() and eth_pio_write().

>Audit-Trail:
>Unformatted: