Date: Tue, 13 May 1997 20:39:36 -0700 (PDT) From: chi@rd.njk.co.jp To: freebsd-gnats-submit@FreeBSD.ORG Subject: kern/3595: param counts not idential between definition and call(in netboot/ns8390.c) Message-ID: <199705140339.UAA11876@hub.freebsd.org> Resent-Message-ID: <199705140340.UAA11927@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 3595 >Category: kern >Synopsis: param counts not idential between definition and call(in netboot/ns8390.c) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 13 20:40:01 PDT 1997 >Last-Modified: >Originator: Chiharu Shibata >Organization: NJK Corporation >Release: FreeBSD-2.1.0R or later >Environment: FreeBSD carrot FreeBSD 2.1.0-RELEASE #0: Sat Jun 1 10:30:42 1996 h-nokubi@sassaby.nokubi.or.jp:/usr/src/sys/compile/GENERIC98 >Description: (Sorry of my poor English.) Functions eth_pio_read() and eth_pio_write() in netboot/ns8390.c are defined that 4 parameters required. But these functios are called only 3 parameters. Here is an abstract of ns8390.c ---- eth_pio_write(test, 8192, sizeof(test)); eth_pio_read(8192, testbuf, sizeof(test)); [snip] eth_pio_read(src, dst, cnt, init) unsigned short src; unsigned char *dst; unsigned short cnt; int init; { ---- >How-To-Repeat: None. >Fix: I think "int init" which is 4th parameter is not necessary. So cut it from definition of eth_pio_read() and eth_pio_write(). >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705140339.UAA11876>