From owner-svn-ports-all@freebsd.org Wed Dec 27 16:54:12 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF684EA1028; Wed, 27 Dec 2017 16:54:12 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F0166D045; Wed, 27 Dec 2017 16:54:12 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-it0-x241.google.com with SMTP id x28so25714971ita.0; Wed, 27 Dec 2017 08:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=MFzVYLvPJfuSz++QbZpWLi223OAg6Q0kZI/IXKDJyPM=; b=cFzDJWZfIuzDG0s+znb4uU+KNPq1CmX07OHjR0TxT/RAUq4jBvVcMg698xPOmwAP6E +2xQMHm45GaVqe6j88Ijh0iSlZ2Bo0UIvM+TnaR84g6c3ZZHtSe05aQrNp8b3K1XYDDZ jSabiaqmAGoLd1ezjeIKPyXgfK8BrV4qax9jbVDzM3n8CqPTbddsCCMqrGdYTXPFMLPG ioaUtRVlHY+HZ3h/nrsLvAFPT6NAWtnbuKHgx1GJ5xi2VOMHpbQJEHlDWlnCgW0bzZTx oJSHIgc9hFTMY9O3tv8/ktYLGXtIJVettAHoMqeLLgSJiPcEpzBkszFE3fOiTlXtQx1E XTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MFzVYLvPJfuSz++QbZpWLi223OAg6Q0kZI/IXKDJyPM=; b=Nt1LkbkIi6rwekjzjxFK9+c0iizAQLxGRNC3Ce1mMeAbiTN92RP9BC3K741GoWopyZ uf0dls13xyqqf1i6wx79bdmSyjVZzRVLypn1ckV388/pTyaCOSWdXBWmo7oy6qYkFxC5 kxmjrnlvginULZqLDA9pNkBWWU2ILFvZi9FC/SEHS5cvaE0wV46j8bpPDOEb90/MOls2 Dizbq1b9myV4cxZznHxJEp1fk8TsDwy/nhPjr6EVEXqkv5GiWub/i7TVsBL/4cd5/tqP 1t58meigQo6jckiLPOs9f8QbDWGvSuKw6S6Si+a0VLlxo1lybaSdClkYxR2VPootYLYB 49gA== X-Gm-Message-State: AKGB3mJqKKm4S2YrRpNfQ9nn6s9A1HeBuWuNONn0mrXXXktJ6ZmiI4ga XIp50x1W0hMNIT4vVh9uaD3U7paW X-Google-Smtp-Source: ACJfBosCD02BBShyxzxdZEPWzE8Gg02TCdPOBe7mjVSnhkiltnw1zCKy0HwAFAxlShvteSBQ5WihFQ== X-Received: by 10.36.25.20 with SMTP id b20mr39303841itb.31.1514393651565; Wed, 27 Dec 2017 08:54:11 -0800 (PST) Received: from imacbsd.acadix.biz ([2605:a000:bc60:2800:216:cbff:feb9:145]) by smtp.gmail.com with ESMTPSA id j21sm17759860ioe.25.2017.12.27.08.54.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2017 08:54:11 -0800 (PST) Subject: Re: svn commit: r456674 - in head/graphics: . libQGLViewer libQGLViewer/files To: Alexey Dokuchaev Cc: Adam Weinberger , yuri@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201712182143.vBILhFND023143@repo.freebsd.org> <20171224135522.GA1693@FreeBSD.org> <6fa2551a-dee7-9388-07fc-6539800b6c5a@freebsd.org> <20171225112028.GA61880@FreeBSD.org> <0e81e642-9157-d8e3-12f2-af08724accf6@gmail.com> <20171226155201.GA90333@FreeBSD.org> <4105e72a-cdd1-c792-7f69-e00bb22d01cb@gmail.com> <20171227082713.GB51426@FreeBSD.org> From: Jason Bacon Message-ID: <5b2cd5f1-5fcb-35d2-9339-dcf97cd11d3f@gmail.com> Date: Wed, 27 Dec 2017 10:54:10 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171227082713.GB51426@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 16:54:12 -0000 On 12/27/17 02:27, Alexey Dokuchaev wrote: > On Tue, Dec 26, 2017 at 02:47:05PM -0600, Jason Bacon wrote: >> On 12/26/17 09:52, Alexey Dokuchaev wrote: >>> On Tue, Dec 26, 2017 at 09:18:02AM -0600, Jason Bacon wrote: >>> ... >>>> 3. Should PORTNAME match the port directory name? >>> Yes, it should, with a few exceptions when e.g. PKGNAMEPREFIX comes to >>> play (examples include CPAN ports, Linux binary ports, etc.). >> Clarifying my point #3: When I said "match" I meant in terms of >> upper/lower case. >> >> Are you suggesting that PORTNAME should also be reduced to lowercase >> to match the directory name? > I'd say most certainly yes, unless I'm overlooking a particular edge-case > where it could be useful, but I cannot think of right now. Do you have > some specific port(s) in mind? > > ./danfe emulators/virtualbox-ose is an example.  DISTNAME and the main binary both contain caps, but the maintainers chose to lowercase both the portname and directory name. math/freemat is a counterexample, where the directory name was lowercased, but PORTNAME contains caps to match DISTNAME. Either of these strategies seems reasonable to me. Mixed case in directory names is a nuisance when trying to use shell auto-complete, for example. I can't think of a strong reason to favor either lowercase or mixed for PORTNAME, though, since pkg is case-insensitive and we'll always need to use -i when grepping for PORTNAME anyway, unless all PORTNAMEs are reduced to lower case. I'd lean toward doing whatever simplifies a particular port.  In the case of lilyterm, I used a lowercase PORTNAME to avoid having to patch the build system, which uses share/doc/lilyterm by default.  This required "GH_PROJECT=LilyTerm", which I think is more palatable than patching.  Had upstream used share/doc/LilyTerm, I would have leaned toward PORTNAME=LilyTerm and dropping GH_TAGNAME.     Jason -- Earth is a beta site.