From owner-cvs-ports@FreeBSD.ORG Sat Mar 6 00:28:20 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AC6E16A4CE; Sat, 6 Mar 2004 00:28:20 -0800 (PST) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id C468A43D1F; Sat, 6 Mar 2004 00:28:19 -0800 (PST) (envelope-from marcus@FreeBSD.org) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) i268RlSq059744; Sat, 6 Mar 2004 03:27:47 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Kris Kennaway In-Reply-To: <20040306082200.GA27791@xor.obsecurity.org> References: <200403060733.i267XKd3044611@repoman.freebsd.org> <20040306081037.GA27564@xor.obsecurity.org> <1078561060.30101.3.camel@shumai.marcuscom.com> <20040306082200.GA27791@xor.obsecurity.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4uD5BgAw8yXmyaOXnQU1" Organization: FreeBSD, Inc. Message-Id: <1078561685.30101.8.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Sat, 06 Mar 2004 03:28:05 -0500 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on creme-brulee.marcuscom.com cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/mplayer-plugin Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2004 08:28:20 -0000 --=-4uD5BgAw8yXmyaOXnQU1 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2004-03-06 at 03:22, Kris Kennaway wrote: > On Sat, Mar 06, 2004 at 03:17:40AM -0500, Joe Marcus Clarke wrote: > > On Sat, 2004-03-06 at 03:10, Kris Kennaway wrote: > > > On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote: > > > > marcus 2004/03/05 23:33:20 PST > > > >=20 > > > > FreeBSD ports repository > > > >=20 > > > > Modified files: > > > > www/mplayer-plugin Makefile=20 > > > > Log: > > > > Add firefox support via WITH_MOZILLA=3Dfirefox. Note: this only = works for > > > > mplayer-plugin. Setting WITH_MOZILLA=3Dfirefox will not work wit= h the > > > > galeon ports. > > >=20 > > > Shouldn't this be WITH_FIREFOX=3Dyes or similar? Most WITH_ and > > > WITHOUT_ variables do not care about the value, and giving them > > > special values makes it difficult to use with configuration tools lik= e > > > 'make config'. > >=20 > > This was done for scaling purposes in the original Mozilla-based ports > > (galeon, galeon2, epiphany). This way, one can specify the mozilla the= y > > want to use (be it mozilla, mozilla-devel, and one point mozilla-vendor= , > > and now firefox). It was easier than defining a large number of macros > > then deciding on precedence. >=20 > OK, going this way, there is precedence for a MOZILLA_PORT variable > (cf APACHE_PORT, GHOSTSCRIPT_PORT) for choosing one of a number of > equivalent choices. I look at converting over to a MOZILLA_PORT, but WITH_MOZILLA predates those other options, and people have grown accustom to it. Joe >=20 > kris --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-4uD5BgAw8yXmyaOXnQU1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBASYuVb2iPiv4Uz4cRAnqzAJ4usm5WO8SMf91ZMhtyJZPPft+rCgCeIUj8 wkENLeFovEL4f4jhwSvJVik= =NNlC -----END PGP SIGNATURE----- --=-4uD5BgAw8yXmyaOXnQU1--