From owner-svn-src-all@freebsd.org Tue Apr 30 15:53:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFB811595FD6; Tue, 30 Apr 2019 15:53:54 +0000 (UTC) (envelope-from tycho@pobox.com) Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4758E8079C; Tue, 30 Apr 2019 15:53:54 +0000 (UTC) (envelope-from tycho@pobox.com) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 5EA1D20A78; Tue, 30 Apr 2019 11:53:47 -0400 (EDT) (envelope-from tycho@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from :message-id:content-type:mime-version:subject:date:in-reply-to :cc:to:references; s=sasl; bh=ZDMjYYOjZyfXiakzrJlI0UxG/X4=; b=fA yzI12zwU0J8+pQFBuD3kW3F0HczQWrIpqBJN6cRvgu3R1duqPOpT5jza+7AGUOu/ OTiaanCka0KCdD2nnlijoUjVLpme20mVkGa/8nLQHc0wcUPUgpwzAZyPw/VZS0Pp oxuUNtJoLM458rs9qiApbWyZNHLWcJYySuBvdcikw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:message-id :content-type:mime-version:subject:date:in-reply-to:cc:to :references; q=dns; s=sasl; b=K082JJ7me3AAw8YqCGR0aQIKXf2ITSQok+ YmvpMyFboGi9BIBADaEUFdVEbT9UN3csIea3kaeoyj5Q5RtjiZQpqKmMkD2mNIWF yKUJrglTzHJ1DV8793MJWG1DUk4Hy5jsYQAVm3YumG69YQVYl8FlkM2GdzPHwiG2 RpRS4c5IE= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 567BB20A77; Tue, 30 Apr 2019 11:53:47 -0400 (EDT) (envelope-from tycho@pobox.com) Received: from [10.0.1.195] (unknown [146.115.68.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 1566520A76; Tue, 30 Apr 2019 11:53:44 -0400 (EDT) (envelope-from tycho@pobox.com) From: Tycho Nightingale Message-Id: <7927F561-6922-4960-90EC-BD36E0190A6F@pobox.com> Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r346958 - head/sys/compat/linuxkpi/common/src Date: Tue, 30 Apr 2019 11:53:42 -0400 In-Reply-To: Cc: Hans Petter Selasky , Niclas Zeising , src-committers , svn-src-all , svn-src-head To: Warner Losh References: <201904301041.x3UAfLvj054368@repo.freebsd.org> <8f360678-2df1-fe7b-cb83-f47923534826@freebsd.org> <2f77d9f2-833d-f614-e193-a369086c01cf@selasky.org> X-Mailer: Apple Mail (2.3445.9.1) X-Pobox-Relay-ID: 222F23C0-6B60-11E9-A01B-EE24A11ADF13-09779102!pb-smtp21.pobox.com X-Rspamd-Queue-Id: 4758E8079C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.952,0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 15:53:55 -0000 > On Apr 30, 2019, at 11:24 AM, Warner Losh wrote: >=20 >=20 > On Tue, Apr 30, 2019 at 9:17 AM Hans Petter Selasky > wrote: > On 4/30/19 3:10 PM, Niclas Zeising wrote: > > On 2019-04-30 12:41, Hans Petter Selasky wrote: > >> Author: hselasky > >> Date: Tue Apr 30 10:41:20 2019 > >> New Revision: 346958 > >> URL: https://svnweb.freebsd.org/changeset/base/346958 = > >> > >> Log: > >> Reduce the number of mutexes after r346645 in the LinuxKPI. > >> Make function macro wrappers for locking and unlocking to ease=20= > >> readability. > >> No functional change. > >> Discussed with: kib@, tychon@ and zeising@ > >=20 > > I was not part of any discussion regarding this. If this is related = to=20 > > https://reviews.freebsd.org/D20097 = I explicitly asked you on gitter to=20= > > hold of for a bit, while we try to figure out why we are seeing=20 > > regressions in graphics with the latest dmar changes. > >=20 > > Can you please revert this since it colludes the dmar graphics = issue,=20 > > and it makes the suggested patch not apply cleanly, which makes it=20= > > harder to get people to help test. > > Thank you! > > Regards >=20 > In response to your request I've collected fixes for all the known=20 > LinuxKPI+DMA issues at: > https://reviews.freebsd.org/D20097 = >=20 > It is based on top of the latest -current. >=20 > Hopefully this will solve the problem. Do you have any idea of when we = might see resolution of this issue? I'd like to see it fixed by Friday = either with fixes or a revert. Do you think that's a reasonable time = frame? If not, what do you think a reasonable time frame will be? I know = we have a number of unknowns to factor in, so my queries are based on = our best guesses. Friday seems reasonable. The issues that have been exposed are that several callers of the Linux = API are not compliant with the documented API. For example according to = the documentation, dma_map_sg() may coalesce entries and our current = implementation does that. This broke some graphics drivers. To support = these drivers, going back to the non-coalesced version is the only path = forward as the callee bugs redefine this API de facto; this is included = in D20097. Also included in D20097 is a fix to ensure sg_dma_len() is equal to = sg->length =E2=80=94 again to address assumptions in drivers. Finally, apparently some drivers load the same DMA address multiple = times without any prior unload. Those drivers need to work too; D20097 = contains a fix. Thanks hps@ for helping out! Tycho=