From owner-freebsd-hackers@freebsd.org Tue Sep 15 12:41:23 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B906A02A12 for ; Tue, 15 Sep 2015 12:41:23 +0000 (UTC) (envelope-from lidl@pix.net) Received: from hydra.pix.net (hydra.pix.net [IPv6:2001:470:e254::4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.pix.net", Issuer "Pix.Com Technologies, LLC CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 169E31FF7 for ; Tue, 15 Sep 2015 12:41:22 +0000 (UTC) (envelope-from lidl@pix.net) Received: from torb.pix.net (verizon.pix.net [71.178.232.3]) (authenticated bits=0) by hydra.pix.net (8.15.2/8.15.2) with ESMTPA id t8FCfLHA068370; Tue, 15 Sep 2015 08:41:21 -0400 (EDT) (envelope-from lidl@pix.net) X-Authentication-Warning: hydra.pix.net: Host verizon.pix.net [71.178.232.3] claimed to be torb.pix.net Subject: Re: Missing "Local system status" To: freebsd-hackers@freebsd.org References: <20150915080318.GA89697@server.rulingia.com> From: Kurt Lidl Message-ID: <55F811F1.7040202@pix.net> Date: Tue, 15 Sep 2015 08:41:21 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150915080318.GA89697@server.rulingia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2015 12:41:23 -0000 On 9/15/15 4:03 AM, Peter Jeremy wrote: > In r183242, installing etc/periodic/daily/430.status-rwho was made > conditional on MK_RCMDS. Despite the name and enable variable, this > script is designed to provide system status, either local or network- > wide, depending on the existence of data in /var/rwho/. > > IMO, reporting local system status shouldn't depend on whether the > rcmds are enabled or not. I believe that we should do either: > 1) Always install 430.status-rwho and rely on ruptime not being invoked > if $MK_RCMDS==no. > 2) Create a new 430.status script that only checks local system status and > install it instead of 430.status-rwho if $MK_RCMDS==no. > > Comments please. > The rwhod daemon is not compiled if MK_RCMDS != "no". Looking at /usr/src/usr.sbin/Makefile: .if ${MK_RCMDS} != "no" SUBDIR+= rwhod .endif So the real argument ought to be if rwhod/ruptime ought to be part of a different MK_xxx, rather than grouped into MK_RCMDS, along with rcp, rsh, rshd, rlogin, and rlogind. -Kurt