Date: Thu, 12 Aug 2010 14:08:32 -0400 (EDT) From: Greg Larkin <glarkin@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: nivit@FreeBSD.org Subject: ports/149584: [PATCH] devel/py-kid: Fix incorrect dependency list with Python 2.4 Message-ID: <201008121808.o7CI8WNE001161@fbsd70.entropy.prv> Resent-Message-ID: <201008121810.o7CIA2bF060929@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 149584
>Category: ports
>Synopsis: [PATCH] devel/py-kid: Fix incorrect dependency list with Python 2.4
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Aug 12 18:10:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Greg Larkin
>Release: FreeBSD 7.0-RELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008
>Description:
py-kid fails to install py24-setuptools when installed with Python 2.4
selected:
make PYTHON_VERSION=python2.4 PYTHON_DEFAULT_VERSION=python2.4 install
This is caused because BUILD_DEPENDS and RUN_DEPENDS are reset in the
Makefile, instead of appending the dependency values on the rhs. The
dependencies inserted by bsd.python.mk are lost in this case.
Deinstallation can fail like so:
===> Deinstalling for devel/py-kid
===> Deinstalling py24-kid-0.9.6_1
/usr/local/bin/easy_install-2.4: not found
pkg_delete: unexec command for '/usr/local/bin/easy_install-2.4 -q -m -S /usr/local/lib/python2.4/site-packages -d /usr/local/lib/python2.4/site-packages -s /usr/local/bin kid==0.9.6' failed
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
The attached patch fixes the problem and removes a portlint warning.
Port maintainer (nivit@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:
--- py25-kid-0.9.6_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/py-kid/Makefile,v
retrieving revision 1.10
diff -u -u -r1.10 Makefile
--- Makefile 4 Jun 2009 21:41:22 -0000 1.10
+++ Makefile 12 Aug 2010 18:04:38 -0000
@@ -37,9 +37,9 @@
.include <bsd.port.pre.mk>
-.if $(PYTHON_REL) < 250
-BUILD_DEPENDS= ${PYTHON_SITELIBDIR}/elementtree/__init__.py:${PORTSDIR}/devel/py-elementtree
-RUN_DEPENDS= ${BUILD_DEPENDS}
+.if ${PYTHON_REL} < 250
+BUILD_DEPENDS+= ${PYTHON_SITELIBDIR}/elementtree/__init__.py:${PORTSDIR}/devel/py-elementtree
+RUN_DEPENDS+= ${BUILD_DEPENDS}
.endif
.include <bsd.port.post.mk>
--- py25-kid-0.9.6_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008121808.o7CI8WNE001161>