From owner-freebsd-current  Wed Nov  5 16:25:36 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id QAA22102
          for current-outgoing; Wed, 5 Nov 1997 16:25:36 -0800 (PST)
          (envelope-from owner-freebsd-current)
Received: from ap3.gluk.apc.org (kushnir@ap3.gluk.apc.org [194.183.183.213])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id QAA22094
          for <freebsd-current@FreeBSD.ORG>; Wed, 5 Nov 1997 16:25:29 -0800 (PST)
          (envelope-from kushnir@ap3.gluk.apc.org)
Received: from localhost (kushnir@localhost)
	by ap3.gluk.apc.org (8.8.5/8.8.5) with SMTP id CAA09518
	for <freebsd-current@FreeBSD.ORG>; Thu, 6 Nov 1997 02:24:21 +0200
Date: Thu, 6 Nov 1997 02:24:21 +0200 (EET)
From: Vladimir Kushnir <kushnir@ap3.gluk.apc.org>
To: freebsd-current@FreeBSD.ORG
Subject: attach_mss for full duplex: possible misspelling?
Message-ID: <Pine.LNX.3.95.971106022311.9509A-100000@ap3.gluk.apc.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Sorry, perhaps I'm just plainly stupid but isn't there a misspelling in an 
attach_mss routine (new sound driver, sound/ad1848.c, lines 1724-1725)? It
calls ad1848_init like 

        ad1848_init("MS Sound System0", hw_config->io_base + 4,
            hw_config->irq,
            hw_config->dma,
            hw_config->dma, 0, hw_config->osp);
    }  

(with both dma equal). Should not it spell 
...
hw_config->dma,
hw_config->dma2,
... instead? At least, this way it initializes my card (CS4231 based
Yamaha OPL3 PnP duplex card) correctly.

Regards,
Vladimir