From owner-svn-ports-head@FreeBSD.ORG Fri Aug 9 19:27:16 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8861F3D9; Fri, 9 Aug 2013 19:27:16 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward2h.mail.yandex.net (forward2h.mail.yandex.net [IPv6:2a02:6b8:0:f05::2]) by mx1.freebsd.org (Postfix) with ESMTP id 3AD112CC1; Fri, 9 Aug 2013 19:27:16 +0000 (UTC) Received: from smtp4h.mail.yandex.net (smtp4h.mail.yandex.net [84.201.186.21]) by forward2h.mail.yandex.net (Yandex) with ESMTP id 8EC377020F3; Fri, 9 Aug 2013 23:27:14 +0400 (MSK) Received: from smtp4h.mail.yandex.net (localhost [127.0.0.1]) by smtp4h.mail.yandex.net (Yandex) with ESMTP id EE07A2C1543; Fri, 9 Aug 2013 23:27:13 +0400 (MSK) Received: from 93.91.10.81.tel.ru (93.91.10.81.tel.ru [93.91.10.81]) by smtp4h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 8sFnh3koXd-RDLK0HAC; Fri, 9 Aug 2013 23:27:13 +0400 Message-ID: <52054290.4090106@passap.ru> Date: Fri, 09 Aug 2013 23:27:12 +0400 From: Boris Samorodov Organization: =?UTF-8?B?0JfQkNCeICLQktCQ0KDQoiI=?= User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130806 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sunpoet Po-Chuan Hsieh Subject: Re: svn commit: r324438 - head/graphics/dcraw References: <201308091418.r79EITQv067141@svn.freebsd.org> <5205054C.6060309@passap.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 09 Aug 2013 19:58:47 +0000 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Aug 2013 19:27:16 -0000 09.08.2013 20:30, Sunpoet Po-Chuan Hsieh пишет: > On Fri, Aug 9, 2013 at 11:05 PM, Boris Samorodov wrote: > >> 09.08.2013 18:18, Sunpoet Po-Chuan Hsieh пишет: >>> Author: sunpoet >>> Date: Fri Aug 9 14:18:29 2013 >>> New Revision: 324438 >>> URL: http://svnweb.freebsd.org/changeset/ports/324438 >>> >>> Log: >>> - Update to 9.19 >>> - Cleanup Makefile header >>> - Update maintainer section >> >> Seems to be a typo: maintainer->maketar. However this change: >> [...] >>> - ${INSTALL} -m 644 >> ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ >>> + sudo ${INSTALL} -m 644 >> ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ >> >> ...is rather strange. Sudo is not a dependency at the port (sudo is not >> at the base either). And the whole thing assumed to be launched with >> root privileges anyway. > > Maintainer section is from line 34 to line 56, therefore maketar target is > for maintainer only. I meant to generate the tarball as normal user, not > superuser. That's why I add "sudo" here. Got it. Some thoughts though: . the name of the section is misleading; standerd tools name MAINTAINER section a place where MAINTAINER and COMMENT are located. Yea, I see caps and non-caps, but it's a misleading name anyway; . so, is this section used only by maintainer? If yes, I'd say that a better place may be Makefile.local. Or if you would like to leave this section at Makefile then use a more strong separations like: # ============= the section is used only by maintainer ========== bla bla # ========++=============== end section ========================= -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve