Date: Fri, 09 Aug 2013 23:27:12 +0400 From: Boris Samorodov <bsam@passap.ru> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r324438 - head/graphics/dcraw Message-ID: <52054290.4090106@passap.ru> In-Reply-To: <CAMHz58QM0q8mbEZofB2X-SG2KZPRCjpDvHAMidPFNOOdCfHSpA@mail.gmail.com> References: <201308091418.r79EITQv067141@svn.freebsd.org> <5205054C.6060309@passap.ru> <CAMHz58QM0q8mbEZofB2X-SG2KZPRCjpDvHAMidPFNOOdCfHSpA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
09.08.2013 20:30, Sunpoet Po-Chuan Hsieh пишет: > On Fri, Aug 9, 2013 at 11:05 PM, Boris Samorodov <bsam@passap.ru> wrote: > >> 09.08.2013 18:18, Sunpoet Po-Chuan Hsieh пишет: >>> Author: sunpoet >>> Date: Fri Aug 9 14:18:29 2013 >>> New Revision: 324438 >>> URL: http://svnweb.freebsd.org/changeset/ports/324438 >>> >>> Log: >>> - Update to 9.19 >>> - Cleanup Makefile header >>> - Update maintainer section >> >> Seems to be a typo: maintainer->maketar. However this change: >> [...] >>> - ${INSTALL} -m 644 >> ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ >>> + sudo ${INSTALL} -m 644 >> ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ >> >> ...is rather strange. Sudo is not a dependency at the port (sudo is not >> at the base either). And the whole thing assumed to be launched with >> root privileges anyway. > > Maintainer section is from line 34 to line 56, therefore maketar target is > for maintainer only. I meant to generate the tarball as normal user, not > superuser. That's why I add "sudo" here. Got it. Some thoughts though: . the name of the section is misleading; standerd tools name MAINTAINER section a place where MAINTAINER and COMMENT are located. Yea, I see caps and non-caps, but it's a misleading name anyway; . so, is this section used only by maintainer? If yes, I'd say that a better place may be Makefile.local. Or if you would like to leave this section at Makefile then use a more strong separations like: # ============= the section is used only by maintainer ========== bla bla # ========++=============== end section ========================= -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52054290.4090106>